PRESIDECMS-2906 Client side validation defensive when validator didnt have client side defined #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defensive-when-validator-didnt-have-client-side-defined'.
DominicWatson
requested changes
Dec 16, 2024
| @@ -53,13 +53,18 @@ | |||
| </cfif> | |||
|
|
|||
| <cfif Len( Trim( formId ) ) and Len( Trim( validationJs ))> | |||
| <cfset event.include( assetId="/js/frontend/formbuilder/" )> | |||
There was a problem hiding this comment.
I'm a little sceptical of this. We're making a dependency on form builder frontend features whereas this layout is for the general preside forms system and is used in both admin and frontend non-formbuilder forms. I feel this logic could/should go somewhere else perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.