From fb1cac7dee2f013df95b085be29cb0028e0b1724 Mon Sep 17 00:00:00 2001 From: Pirmin Kalberer Date: Fri, 1 Sep 2023 08:47:50 +0200 Subject: [PATCH] Better SeekFrom::End error message --- src/buffered_range_client.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/buffered_range_client.rs b/src/buffered_range_client.rs index db25648..1312d20 100644 --- a/src/buffered_range_client.rs +++ b/src/buffered_range_client.rs @@ -230,9 +230,11 @@ pub(crate) mod sync { self.buffer.offset = p as usize; Ok(p) } + // TODO: we should support SeekFrom::End (e.g. for Parquet) + // With a HEAD request we would often get the file length SeekFrom::End(_) => Err(std::io::Error::new( std::io::ErrorKind::Other, - "Request size unkonwn", + "SeekFrom::End not supported for HTTP streams", )), SeekFrom::Current(p) => { self.buffer.offset = self.buffer.offset.saturating_add_signed(p as isize);