Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Commits Bug]: false footer detection (mid paragraph) #713

Open
1 task done
Kangie opened this issue Nov 10, 2024 · 0 comments
Open
1 task done

[Commits Bug]: false footer detection (mid paragraph) #713

Kangie opened this issue Nov 10, 2024 · 0 comments
Labels

Comments

@Kangie
Copy link

Kangie commented Nov 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Commit message contains the following:

net-misc/curl: add 8.11.0

There are a number of patches attached to this release. Normally
I'd generate a downstream tarball, or wait for the next point release,
however: we have signed tarballs for curl and that's worth preserving,
and the next point release has been pushed back until mid-December due
to upstream availability.

Signed-off-by: Matt Jolly <kangie@gentoo.org>

pkgcheck outputs:

commit
  InvalidCommitMessage: commit 646acc672343: empty line 8 in footer
  InvalidCommitMessage: commit 646acc672343: missing empty line before tags
  InvalidCommitMessage: commit 646acc672343: non-tag in footer, line 6: 'and the next point release has been pushed back until mid-December due'
  InvalidCommitMessage: commit 646acc672343: non-tag in footer, line 7: 'to upstream availability.'

Expected Behavior

Footer detection should not start mid paragraph. Look for a line break above the footer.

master commit id

6166e0b9c023

HEAD link

https://github.com/Kangie/gentoo/tree/silly-curl

pkgcheck version

pkgcheck 0.10.31

pkgcore version

pkgcore 0.12.28

git remotes configuration

kangie-repo git@github.com:Kangie/gentoo.git (fetch)
kangie-repo git@github.com:Kangie/gentoo.git (push)
origin git+ssh://git@git.gentoo.org/repo/gentoo.git (fetch)
origin git+ssh://git@git.gentoo.org/repo/gentoo.git (push)

@Kangie Kangie added the bug label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant