Merge pull request #39 from bozana/9959

pkp/pkp-lib#9959 use createTextNode for preprint title and subtitle i…
pkp · May 22, 2024 · f7767ff · f7767ff
2 parents d6c7605 + 9ceff74
commit f7767ff
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/filter/PreprintCrossrefXmlFilter.php b/filter/PreprintCrossrefXmlFilter.php
@@ -159,7 +159,7 @@ public function createPostedContentNode($doc, $publication, $submission)
 
         // contributors
         $authors = $publication->getData('authors');
-        if (!empty($authors)) {
+        if ($authors->count() != 0) {
             $contributorsNode = $doc->createElementNS($deployment->getNamespace(), 'contributors');
 
             $isFirst = true;
@@ -221,17 +221,19 @@ public function createPostedContentNode($doc, $publication, $submission)
 
         // Titles
         $titlesNode = $doc->createElementNS($deployment->getNamespace(), 'titles');
-        $titlesNode->appendChild($doc->createElementNS($deployment->getNamespace(), 'title', $publication->getLocalizedTitle($submission->getData('locale'), 'html')));
+        $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'title'));
+        $node->appendChild($doc->createTextNode($publication->getLocalizedTitle($submission->getData('locale'), 'html')));
         if ($subtitle = $publication->getLocalizedSubTitle($submission->getData('locale'), 'html')) {
-            $titlesNode->appendChild($doc->createElementNS($deployment->getNamespace(), 'subtitle', $subtitle));
+            $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'subtitle'));
+            $node->appendChild($doc->createTextNode($publication->getLocalizedTitle($subtitle, 'html')));
         }
         $postedContentNode->appendChild($titlesNode);
 
         // Posted date
         $postedContentNode->appendChild($this->createPostedDateNode($doc, $publication->getData('datePublished')));
 
         // abstract
-        $abstracts = $publication->getData('abstract');
+        $abstracts = $publication->getData('abstract') ?: [];
         foreach($abstracts as $lang => $abstract) {
             $abstractNode = $doc->createElementNS($deployment->getJATSNamespace(), 'jats:abstract');
             $abstractNode->setAttributeNS($deployment->getXMLNamespace(), 'xml:lang', LocaleConversion::getIso1FromLocale($lang));