pkp/pkp-lib#10306 added not to perform assertion on void return type …

…method
pkp · Sep 4, 2024 · 0f630e3 · 0f630e3
1 parent 6aa8920
commit 0f630e3
Show file tree

Hide file tree

Showing 11 changed files with 33 additions and 11 deletions.
diff --git a/tests/jobs/doi/DepositIssueTest.php b/tests/jobs/doi/DepositIssueTest.php
@@ -100,6 +100,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(DoiRepository::class, $doiRepoMock);
 
-        $this->assertNull($depositIssueJob->handle());
+        $depositIssueJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/notifications/IssuePublishedNotifyUsersTest.php b/tests/jobs/notifications/IssuePublishedNotifyUsersTest.php
@@ -82,6 +82,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(EmailTemplateRepository::class, $emailTemplateRepoMock);
 
-        $this->assertNull($issuePublishedNotifyUsersJob->handle());
+        $issuePublishedNotifyUsersJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/notifications/OpenAccessMailUsersTest.php b/tests/jobs/notifications/OpenAccessMailUsersTest.php
@@ -102,6 +102,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(EmailTemplateRepository::class, $emailTemplateRepoMock);
 
-        $this->assertNull($openAccessMailUsersJob->handle());
+        $openAccessMailUsersJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/CompileCounterSubmissionDailyMetricsTest.php b/tests/jobs/statistics/CompileCounterSubmissionDailyMetricsTest.php
@@ -81,6 +81,8 @@ public function testRunSerializedJob(): void
         DAORegistry::registerDAO('TemporaryItemRequestsDAO', $temporaryItemRequestsDAOMock);
 
 
-        $this->assertNull($compileCounterSubmissionDailyMetricsJob->handle());
+        $compileCounterSubmissionDailyMetricsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/CompileCounterSubmissionInstitutionDailyMetricsTest.php b/tests/jobs/statistics/CompileCounterSubmissionInstitutionDailyMetricsTest.php
@@ -81,6 +81,8 @@ public function testRunSerializedJob(): void
         DAORegistry::registerDAO('TemporaryItemRequestsDAO', $temporaryItemRequestsDAOMock);
 
 
-        $this->assertNull($compileCounterSubmissionInstitutionDailyMetricsJob->handle());
+        $compileCounterSubmissionInstitutionDailyMetricsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/CompileIssueMetricsTest.php b/tests/jobs/statistics/CompileIssueMetricsTest.php
@@ -59,6 +59,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryTotalsDAO', $temporaryTotalsDAOMock);
 
-        $this->assertNull($compileIssueMetricsJob->handle());
+        $compileIssueMetricsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/CompileSubmissionGeoDailyMetricsTest.php b/tests/jobs/statistics/CompileSubmissionGeoDailyMetricsTest.php
@@ -70,6 +70,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryItemInvestigationsDAO', $temporaryItemInvestigationsDAOMock);
 
-        $this->assertNull($compileSubmissionGeoDailyMetricsJob->handle());
+        $compileSubmissionGeoDailyMetricsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/CompileUniqueInvestigationsTest.php b/tests/jobs/statistics/CompileUniqueInvestigationsTest.php
@@ -59,6 +59,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryItemInvestigationsDAO', $temporaryItemInvestigationsDAOMock);
 
-        $this->assertNull($compileUniqueInvestigationsJob->handle());
+        $compileUniqueInvestigationsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/CompileUniqueRequestsTest.php b/tests/jobs/statistics/CompileUniqueRequestsTest.php
@@ -59,6 +59,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryItemRequestsDAO', $temporaryItemRequestsDAOMock);
 
-        $this->assertNull($compileUniqueRequestsJob->handle());
+        $compileUniqueRequestsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/DeleteUsageStatsTemporaryRecordsTest.php b/tests/jobs/statistics/DeleteUsageStatsTemporaryRecordsTest.php
@@ -89,6 +89,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryInstitutionsDAO', $temporaryInstitutionsDAOMock);
 
-        $this->assertNull($deleteUsageStatsTemporaryRecordsJob->handle());
+        $deleteUsageStatsTemporaryRecordsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
diff --git a/tests/jobs/statistics/ProcessUsageStatsLogFileTest.php b/tests/jobs/statistics/ProcessUsageStatsLogFileTest.php
@@ -104,11 +104,13 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryInstitutionsDAO', $temporaryInstitutionsDAOMock);
 
-        $this->assertNull($processUsageStatsLogFileJob->handle());
+        $processUsageStatsLogFileJob->handle();
 
         if ($dummyFile) {
             unlink($dummyFile);
         }
+
+        $this->expectNotToPerformAssertions();
     }
 
     /**