Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10392 Masthead styling and locale key fix for masthead item under about #1734

Merged
merged 3 commits into from
Oct 22, 2024
Merged

pkp/pkp-lib#10392 Masthead styling and locale key fix for masthead item under about #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a69c44c
pkp/pkp-lib#10392 Masthead styling
bozana Oct 22, 2024
48bb7f3
fix locale key for masthead nav item under about
bozana Oct 22, 2024
9dfc945
pkp/pkp-lib#10392 submodule update ##bozana/i10392##
bozana Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
cypress/tests/**/*
lib/pkp/cypress/**/*
cypress/support/**/*
package.json
plugins/themes/default/**/*

package.json
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 4 files
+2 −2 classes/core/Dispatcher.php
+4 −1 locale/en/common.po
+18 −20 templates/frontend/pages/editorialHistory.tpl
+30 −32 templates/frontend/pages/editorialMasthead.tpl
1 change: 1 addition & 0 deletions plugins/themes/default/styles/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
@import "pages/indexSite.less";
@import "pages/login.less";
@import "pages/lostPassword.less";
@import "pages/masthead.less";
@import "pages/register.less";
@import "pages/search.less";
@import "pages/viewFile.less";
Expand Down
56 changes: 56 additions & 0 deletions plugins/themes/default/styles/pages/masthead.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/*
* @file plugins/themes/default/styles/pages/masthead.less
*
* Copyright (c) 2014-2024 Simon Fraser University
* Copyright (c) 2003-2024 John Willinsky
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
*
* @brief Styles applying to the masthead and editorial history page
* @link templates/frontend/pages/editorialMasthead.tpl
* @link templates/frontend/pages/editorialHistory.tpl
*/

.page_masthead {
h2 {
margin-top: @double;
margin-bottom: @base;
}

.user_listing {
li {
margin-bottom: @double;
}
li > span {
display: block;
}
list-style-type: none;
padding: 0;
margin-top: @half;

.name {
font-weight: bold;
}

.affiliation {
font-size: @font-sml;
color: @text-light;
}

.date_start {
font-size: @font-sml;
color: @text-light;
}

.orcid {
font-size: @font-sml;
margin-left: 0.2rem;
margin-right: 0.2rem;
}

.orcid_icon {
width: 1.4rem;
height: 1.4rem;
margin: 0;
}
}
}
2 changes: 1 addition & 1 deletion registry/navigationMenus.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<navigationMenuItem title="navigation.about" type="NMI_TYPE_ABOUT">
<navigationMenuItem title="about.aboutContext" type="NMI_TYPE_ABOUT" />
<navigationMenuItem title="about.submissions" type="NMI_TYPE_SUBMISSIONS" />
<navigationMenuItem title="common.masthead" type="NMI_TYPE_MASTHEAD" />
<navigationMenuItem title="common.editorialMasthead" type="NMI_TYPE_MASTHEAD" />
<navigationMenuItem title="manager.setup.privacyStatement" type="NMI_TYPE_PRIVACY" />
<navigationMenuItem title="about.contact" type="NMI_TYPE_CONTACT" />
</navigationMenuItem>
Expand Down