#10375 Corectly consider roles removed from masthead with the custom …

…order of the masthead roles in website settings
pkp · Sep 9, 2024 · 1765240 · 1765240
1 parent d33f414
commit 1765240
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/classes/components/forms/context/PKPAppearanceMastheadForm.php b/classes/components/forms/context/PKPAppearanceMastheadForm.php
@@ -52,7 +52,7 @@ public function __construct($action, $locales, $context)
             ->toArray();
 
         // sort the mashead roles in their saved order
-        $sortedAllMastheadUserGroups = array_replace(array_flip($savedMastheadUserGroupIdsOrder), $allMastheadUserGroups);
+        $sortedAllMastheadUserGroups = array_replace(array_intersect_key(array_flip($savedMastheadUserGroupIdsOrder), $allMastheadUserGroups), $allMastheadUserGroups);
 
         foreach ($sortedAllMastheadUserGroups as $userGroup) {
             $mastheadOptions[] = [

diff --git a/pages/about/AboutContextHandler.php b/pages/about/AboutContextHandler.php
@@ -83,7 +83,7 @@ public function editorialMasthead($args, $request)
             ->toArray();
 
         // sort the masthead roles in their saved order for display
-        $mastheadRoles = array_replace(array_flip($savedMastheadUserGroupIdsOrder), $allMastheadUserGroups);
+        $mastheadRoles = array_replace(array_intersect_key(array_flip($savedMastheadUserGroupIdsOrder), $allMastheadUserGroups), $allMastheadUserGroups);
 
         $allUsersIdsGroupedByUserGroupId = Repo::userGroup()->getMastheadUserIdsByRoleIds($mastheadRoles, $context->getId());
 
@@ -152,7 +152,7 @@ public function editorialHistory($args, $request)
             ->toArray();
 
         // sort the masthead roles in their saved order for display
-        $mastheadRoles = array_replace(array_flip($savedMastheadUserGroupIdsOrder), $allMastheadUserGroups);
+        $mastheadRoles = array_replace(array_intersect_key(array_flip($savedMastheadUserGroupIdsOrder), $allMastheadUserGroups), $allMastheadUserGroups);
 
         $allUsersIdsGroupedByUserGroupId = Repo::userGroup()->getMastheadUserIdsByRoleIds($mastheadRoles, $context->getId(), UserUserGroupStatus::STATUS_ENDED);