#10402 Do not attempt to notify disabled users

pkp · Sep 12, 2024 · d2f7fa5 · d2f7fa5
1 parent f2f64dd
commit d2f7fa5
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/controllers/grid/queries/QueryNotesGridHandler.php b/controllers/grid/queries/QueryNotesGridHandler.php
@@ -310,6 +310,11 @@ protected function insertedNoteNotify(Note $note): void
             if ($userId == $sender->getId()) {
                 continue;
             }
+            $recipient = Repo::user()->get($userId);
+            // Do not attempt to notify disabled users. (pkp/pkp-lib#10402)
+            if (!$recipient) {
+                continue;
+            }
 
             // Notify the user of a new query.
             $notification = $notificationManager->createNotification(
@@ -330,12 +335,10 @@ protected function insertedNoteNotify(Note $note): void
                     $userId,
                     (int) $context->getId()
                 )
-            )
-            ) {
+            )) {
                 continue;
             }
 
-            $recipient = Repo::user()->get($userId);
             $mailable = $this->getStageMailable($context, $submission)
                 ->sender($sender)
                 ->recipients([$recipient])