-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OMP] Review ONIX export for calls to get localized data #10046
Comments
PRs for review:
@bozana could you review whenever you're able? There's one issue I'm seeing that maybe we can take a look at together and I've made a note in the PR. Will forward-port once ready. |
Hi @kaitlinnewson, I took a look and left a few comments... We can see them today together, if you want... :-) |
…nd coverImageUrl
@bozana ready for another review |
@kaitlinnewson, great, thanks a lot! |
@bozana I've updated the PR - ready to merge! |
#10046 Use default locale for user full name when passed
pkp/pkp-lib#10046 fix onix export calls to get localized data
@bozana Forward-ported and the PRs are linked above. |
pkp/pkp-lib#10046 fix onix export calls to get localized data
pkp/pkp-lib#10046 fix onix export calls to get localized data
All merge, thanks a lot @kaitlinnewson! |
Describe the bug
The ONIX plugin has calls to
getLocalized
... functions, which will get localized data based on the exporting user's current locale.Metadata exports shouldn't depend on the current locale. In cases where the exporting standard doesn't support multilingual data, it's better to rely on the publication's primary locale (
$publication->getData('locale')
) in deciding which language to include.The text was updated successfully, but these errors were encountered: