Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMP] Review ONIX export for calls to get localized data #10046

Closed
asmecher opened this issue Jun 12, 2024 · 7 comments
Closed

[OMP] Review ONIX export for calls to get localized data #10046

asmecher opened this issue Jun 12, 2024 · 7 comments
Assignees
Milestone

Comments

@asmecher
Copy link
Member

Describe the bug
The ONIX plugin has calls to getLocalized... functions, which will get localized data based on the exporting user's current locale.

Metadata exports shouldn't depend on the current locale. In cases where the exporting standard doesn't support multilingual data, it's better to rely on the publication's primary locale ($publication->getData('locale')) in deciding which language to include.

@asmecher asmecher changed the title Review ONIX export for calls to get localized data [OMP] Review ONIX export for calls to get localized data Jun 12, 2024
@kaitlinnewson kaitlinnewson self-assigned this Jul 19, 2024
kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Sep 16, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Sep 17, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Sep 17, 2024
@kaitlinnewson
Copy link
Member

kaitlinnewson commented Sep 20, 2024

PRs for review:

@bozana could you review whenever you're able? There's one issue I'm seeing that maybe we can take a look at together and I've made a note in the PR.

Will forward-port once ready.

@kaitlinnewson kaitlinnewson moved this from Todo to In Progress in DOAB / OMP Data Exchange Sep 25, 2024
@bozana
Copy link
Collaborator

bozana commented Sep 26, 2024

Hi @kaitlinnewson, I took a look and left a few comments... We can see them today together, if you want... :-)

kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Sep 26, 2024
kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Sep 27, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Sep 27, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Sep 27, 2024
@kaitlinnewson
Copy link
Member

@bozana ready for another review

@bozana
Copy link
Collaborator

bozana commented Sep 30, 2024

@kaitlinnewson, great, thanks a lot!
I left just one minor comment :-)
We can then merge...

kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Oct 1, 2024
@kaitlinnewson
Copy link
Member

@bozana I've updated the PR - ready to merge!

bozana added a commit that referenced this issue Oct 1, 2024
#10046 Use default locale for user full name when passed
bozana added a commit to pkp/omp that referenced this issue Oct 1, 2024
pkp/pkp-lib#10046 fix onix export calls to get localized data
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Oct 2, 2024
@kaitlinnewson kaitlinnewson added this to the 3.3.0-20 milestone Oct 2, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Oct 2, 2024
@kaitlinnewson
Copy link
Member

@bozana Forward-ported and the PRs are linked above.

bozana added a commit to pkp/omp that referenced this issue Oct 7, 2024
pkp/pkp-lib#10046 fix onix export calls to get localized data
bozana added a commit to pkp/omp that referenced this issue Oct 7, 2024
pkp/pkp-lib#10046 fix onix export calls to get localized data
@bozana
Copy link
Collaborator

bozana commented Oct 7, 2024

All merge, thanks a lot @kaitlinnewson!

@github-project-automation github-project-automation bot moved this from In Progress to Done in DOAB / OMP Data Exchange Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants