Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup/refactor for ORCID integration #10131

Closed
2 tasks
ewhanson opened this issue Jun 25, 2024 · 3 comments
Closed
2 tasks

Minor cleanup/refactor for ORCID integration #10131

ewhanson opened this issue Jun 25, 2024 · 3 comments
Assignees
@ewhanson @taslangraham
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5 Internal

Comments

@ewhanson
Copy link
Collaborator

The ORCID refactor from #9771 left a few areas where code duplication/reuse could be improved.

  • Refactor OrcidController to abstract more "common sense" checks
  • Abstract out `OrcidManager::getApiTypes() in some form (see note from original PR).
@ewhanson ewhanson added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Jun 25, 2024
@ewhanson ewhanson added this to the 3.5 Internal milestone Jun 25, 2024
@ewhanson ewhanson self-assigned this Jun 25, 2024
@ewhanson ewhanson moved this from Backlog to Todo in Metadata and Distribution Jun 25, 2024
@taslangraham taslangraham self-assigned this Sep 5, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 5, 2024
@taslangraham
pkp#10131 cleanup for Orcid implementation cleanup
43e51b3
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 5, 2024
@taslangraham
pkp#10131 cleanup for Orcid implementation cleanup
59a8c0c
taslangraham added a commit to taslangraham/ojs that referenced this issue Sep 5, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
da19dac
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 5, 2024
@taslangraham
pkp#10131 cleanup for ORCID implementation
420c498
taslangraham added a commit to taslangraham/omp that referenced this issue Sep 5, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
ce5c8a8
taslangraham added a commit to taslangraham/omp that referenced this issue Sep 5, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
caf6192
@taslangraham taslangraham mentioned this issue Sep 5, 2024
Merged
taslangraham added a commit to taslangraham/ops that referenced this issue Sep 5, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
9f848e9
@taslangraham taslangraham mentioned this issue Sep 5, 2024
Merged
taslangraham added a commit to taslangraham/ojs that referenced this issue Sep 5, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
32b1f05
This was referenced Sep 5, 2024
Merged
Merged
@taslangraham
Copy link
Contributor

taslangraham commented Sep 6, 2024 •
edited
Loading

I've added a PR for this @ewhanson.

PRs

Submodule updates

@ewhanson ewhanson moved this from Todo to Under Development in Metadata and Distribution Sep 10, 2024
@ewhanson
Copy link
Collaborator Author

Hey @taslangraham, just a few minor request, otherwise looks good!

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 11, 2024
@taslangraham
pkp#10131 cleanup for ORCID implementation
50e0ea8
taslangraham added a commit to taslangraham/ojs that referenced this issue Sep 11, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
81d92ca
taslangraham added a commit to taslangraham/omp that referenced this issue Sep 11, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
2a54ae5
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 11, 2024
@taslangraham
pkp#10131 cleanup for ORCID implementation
5df9954
taslangraham added a commit to taslangraham/omp that referenced this issue Sep 11, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
f0a9afa
taslangraham added a commit to taslangraham/omp that referenced this issue Sep 11, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
b3d2671
taslangraham added a commit to taslangraham/ojs that referenced this issue Sep 11, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
2d921ee
taslangraham added a commit to taslangraham/ops that referenced this issue Sep 11, 2024
@taslangraham
pkp/pkp-lib#10131 submodule update
4eafe5a
ewhanson pushed a commit that referenced this issue Sep 11, 2024
@taslangraham @ewhanson
#10131 cleanup for ORCID implementation
a38102f
ewhanson pushed a commit to pkp/ops that referenced this issue Sep 11, 2024
@taslangraham @ewhanson
pkp/pkp-lib#10131 submodule update
42b5469
ewhanson pushed a commit to pkp/ojs that referenced this issue Sep 11, 2024
@taslangraham @ewhanson
pkp/pkp-lib#10131 submodule update
0ec0f46
ewhanson pushed a commit to pkp/omp that referenced this issue Sep 11, 2024
@taslangraham @ewhanson
pkp/pkp-lib#10131 submodule update
672d661
@ewhanson
Copy link
Collaborator Author

Thanks @taslangraham, all merged!

@github-project-automation github-project-automation bot moved this from Under Development to Done in Metadata and Distribution Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewhanson ewhanson

@taslangraham taslangraham

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
Metadata and Distribution
Status: Done
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@ewhanson @taslangraham