Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting authenticated ORCIDs should revoke tokens #10318

Closed
ewhanson opened this issue Aug 14, 2024 · 6 comments
Closed

Deleting authenticated ORCIDs should revoke tokens #10318

ewhanson opened this issue Aug 14, 2024 · 6 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@ewhanson
Copy link
Collaborator

Describe the issue
When a user authenticates their ORCID and links it to OJS, an access and refresh token are created and stored in the database. Currently, when an ORCID is deleted, the ORCID along with the tokens are deleted from the database, but they are not revoked from ORCID. Whenever an authenticated ORCID is removed from OJS, the corresponding tokens should be removed as well as described in the ORCID documentaiton.

For the FieldOrcid Vue component, this revocation can be done as part of the OJS API call here:

public function deleteForAuthor(Request $illuminateRequest): JsonResponse

This will need to be handled separately for the user profile ORCID connection workflow.

What application are you using?
OJS, OMP, and OPS version 3.5, main branch

Additional information
This will apply only to the main branch.

@ewhanson ewhanson added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Aug 14, 2024
@ewhanson ewhanson added this to the 3.5.0 LTS milestone Aug 14, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 20, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 21, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 21, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 22, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 22, 2024
taslangraham added a commit to taslangraham/ojs that referenced this issue Aug 22, 2024
@taslangraham taslangraham self-assigned this Aug 22, 2024
taslangraham added a commit to taslangraham/ops that referenced this issue Aug 22, 2024
taslangraham added a commit to taslangraham/omp that referenced this issue Aug 22, 2024
@taslangraham
Copy link
Contributor

Ready for review @ewhanson

Description

  • Revoke ORCID tokens from ORCID when they are removed from a user’s profile or author details.
  • Implemented a job to make HTTP call to the ORCID API, revoking a user's access tokens for the application.
  • Revoking an ORCID linked to a user’s profile does not revoke tokens linked to their author details for individual submissions, and vice versa.

PRs:

pkp lib - https://github.com/pkp/pkp-lib/pull/10333/files

submodule updates

taslangraham added a commit to taslangraham/omp that referenced this issue Aug 22, 2024
@ewhanson
Copy link
Collaborator Author

Thanks @taslangraham. Looks good! Just a few comments in the PR.

I also had a question about the placement of the delete button:

Screenshot of user profile with ORCID

I'm not sure how easy it would be, but if possible, I think it would be better if it were in-line with the ORCID URL, same as the Vue component.

@taslangraham
Copy link
Contributor

@ewhanson thanks for the review.

In response to your suggestion,

I'm not sure how easy it would be, but if possible, I think it would be better if it were in-line with the ORCID URL, same as the Vue component.

I'm working on a few UI changes on #10319, I could apply the suggested UI change as a part of that issue

@ewhanson
Copy link
Collaborator Author

That sounds good @taslangraham, feel free to make that UI change there.

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/ojs that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/ojs that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/omp that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/ops that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/ops that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/omp that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/ojs that referenced this issue Aug 26, 2024
@taslangraham
Copy link
Contributor

@ewhanson I've made the suggested updates. Please take a look

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/ojs that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/omp that referenced this issue Aug 26, 2024
taslangraham added a commit to taslangraham/omp that referenced this issue Aug 27, 2024
taslangraham added a commit to taslangraham/ojs that referenced this issue Aug 27, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 27, 2024
taslangraham added a commit to taslangraham/omp that referenced this issue Aug 27, 2024
ewhanson pushed a commit to pkp/ojs that referenced this issue Aug 27, 2024
ewhanson pushed a commit to pkp/omp that referenced this issue Aug 27, 2024
@ewhanson
Copy link
Collaborator Author

All merged, thanks @taslangraham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
Development

No branches or pull requests

2 participants