Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor announcements as an Eloquent Model #10328

Closed
3 tasks done
Vitaliy-1 opened this issue Aug 20, 2024 · 4 comments
Closed
3 tasks done

Refactor announcements as an Eloquent Model #10328

Vitaliy-1 opened this issue Aug 20, 2024 · 4 comments
Assignees
@Vitaliy-1 @pkp-dev-infrastructure
Labels
Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem.
Milestone
3.5 Internal

Comments

@Vitaliy-1
Copy link
Collaborator

Vitaliy-1 commented Aug 20, 2024 •
edited
Loading

Announcement is an entity that utilises settings table. This makes its refactoring to the Eloquent model a non-trivial task.
As a part of this issue

  • Adapt Eloquent model to work with data from a settings table as usual properties/attributes
  • Adapt Eloquent to work with localized properties
  • Refactor Announcement entity

This will serve as an example for refactoring of other entities, such as: genres and controlled vocabulary.
@Vitaliy-1 Vitaliy-1 added the Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem. label Aug 20, 2024
@Vitaliy-1 Vitaliy-1 added this to the 3.5 Internal milestone Aug 20, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 2, 2024
@Vitaliy-1
pkp#10328 Refactor Announcements
414b07c
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 2, 2024
@Vitaliy-1
pkp#10328 Refactor Announcements
9a7654f
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 3, 2024
@Vitaliy-1
pkp#10328 Remove announcement Repository class
204ca6a
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 9, 2024
@Vitaliy-1
pkp#10328 Refactor announcement controller and re-add Repository
ee7760a
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 9, 2024
@Vitaliy-1
pkp#10328 Refactor Announcements
a6c02f8
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 9, 2024
@Vitaliy-1
pkp#10328 Remove announcement Repository class
5a091e8
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 9, 2024
@Vitaliy-1
pkp#10328 Refactor announcement controller and re-add Repository
5fdcf94
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 10, 2024
@Vitaliy-1
pkp#10328 Refactor Announcements
5a6eac0
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Sep 10, 2024
@Vitaliy-1
pkp/pkp-lib#10328 Refactor Announcements
4b63532
@Vitaliy-1
Copy link
Collaborator Author

PRs
pkp-lib: #10382
OJS: pkp/ojs#4433

@asmecher
Copy link
Member

Added some comments on the PR -- but this is looking very good, @Vitaliy-1, thanks!

@asmecher asmecher mentioned this issue Sep 10, 2024
Open
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 10, 2024
@Vitaliy-1
pkp#10328 Fix multilingual attributes retrieval
316ec82
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 11, 2024
@Vitaliy-1
pkp#10328 Fix method calls
500c422
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 12, 2024
@Vitaliy-1
pkp#10328 Refactor Announcements
29430fd
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 12, 2024
@Vitaliy-1
pkp#10328 Fix multilingual attributes retrieval
e07a6f6
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 12, 2024
@Vitaliy-1
pkp#10328 Fix method calls
caa6428
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 12, 2024
@Vitaliy-1
pkp#10328 Resolve conflict with HasCamelCasing
a3ed205
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Sep 12, 2024
@Vitaliy-1
pkp/pkp-lib#10328 Refactor Announcements
d59ca14
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 16, 2024
@Vitaliy-1
pkp#10328 Fix sql for postgres
d6dbb9f
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 16, 2024
@Vitaliy-1
pkp#10328 Refactor Announcements
4d8a002
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 16, 2024
@Vitaliy-1
pkp#10328 Fix multilingual attributes retrieval
e2919fd
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 16, 2024
@Vitaliy-1
pkp#10328 Fix method calls
e6b0237
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 16, 2024
@Vitaliy-1
pkp#10328 Resolve conflict with HasCamelCasing
62adea1
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 16, 2024
@Vitaliy-1
pkp#10328 Fix sql for postgres
5253484
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Sep 16, 2024
@Vitaliy-1
pkp/pkp-lib#10328 Refactor Announcements
bb27c5b
@Vitaliy-1
Copy link
Collaborator Author

@touhidurabir, can you review this?
@Hafsa-Naeem, I see that you are also working on refactoring of entity which deals with settings table. Feel free to make comments if you'd like.

@touhidurabir
Copy link
Member

@Vitaliy-1 I have added reviews at #10382 (review)

@Vitaliy-1 Vitaliy-1 mentioned this issue Sep 26, 2024
Open
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Refactor Announcements
c9cda06
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Fix multilingual attributes retrieval
cc6b601
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Fix method calls
a978805
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Resolve conflict with HasCamelCasing
1d4b875
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Fix sql for postgres
c4c3219
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Remove announcement delete hooks
d841f70
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Replace getAttribute method with property calls
0f5c2aa
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp#10328 Fix dates as Carbon, fillables and garded attributes
070aa6f
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Sep 30, 2024
@Vitaliy-1
pkp/pkp-lib#10328 Refactor Announcements
a84825a
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Oct 1, 2024
@Vitaliy-1
pkp/pkp-lib#10328 Date to Carbon
911efa8
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Oct 1, 2024
@Vitaliy-1
pkp#10328 Replace TODOs with issues
4e0933e
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Oct 1, 2024
@Vitaliy-1
pkp/pkp-lib#10328 Refactor Announcements
e9fbcb1
Vitaliy-1 added a commit to Vitaliy-1/ojs that referenced this issue Oct 1, 2024
@Vitaliy-1
pkp/pkp-lib#10328 Date to Carbon
5d5b768
Vitaliy-1 added a commit that referenced this issue Oct 1, 2024
@Vitaliy-1
Merge pull request #10382 from Vitaliy-1/i10328_eloquent_announcements
ffbc59a 
#10328 Refactor Announcements
Vitaliy-1 added a commit to pkp/ojs that referenced this issue Oct 1, 2024
@Vitaliy-1
Merge pull request #4433 from Vitaliy-1/i10328_eloquent_announcements
8de7f2f 
pkp/pkp-lib#10328 eloquent announcements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vitaliy-1 Vitaliy-1

@pkp-dev-infrastructure pkp-dev-infrastructure

Labels
Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
4 participants
@asmecher @touhidurabir @Vitaliy-1 @pkp-dev-infrastructure