-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track author Orcid verification request state in FieldOrcid component #10389
Comments
@taslangraham, would you mind having a look at this one? Let me know if you need any further details beyond the description above. Thanks! |
@ewhanson Yes, I'll look into it. |
Ready for review @ewhanson PRspkp-lib - #10407 Submodule updates |
Hey @taslangraham, one minor comment, otherwise looks good. After you make the change, feel free to merge. |
#10389 Track author Orcid verification request state
pkp/pkp-lib#10389 track author Orcid verification request state
All merged! Thanks for the review @ewhanson |
Describe the issue
This issue concerns the ORCID verification functionality for authors within the contributor workflow. Currently, there is a button to trigger an email to request authors verify their ORCID. This button is part of a Vue component that currently tracks the state of the action locally. This means if you send a request to an author, you will see that the request has been sent, but if you reopen the contributor form, the request button state will be set back to its default. This state should be tracked to provide additional information to authors/editors.
Describe the solution
This local state should be moved to the author settings table to track across page refreshes as something like a boolean
orcidVerificationSent
, which will need to be added toauthor.json
in order to save the value to theauthor_settings
table.The Vue component should track this value and conditionally display the
FieldOrcid
component in its "verification sent" state as long as the request has been sent once. (The ability to resend the request once it has been sent already is being handled separately, see: #10319).This value should be set to true when the request is sent and removed from the database once the ORCID has been verified.
This is currently only needed as part of the author/contributor workflow for sending ORCID verification requests as users are able to do so directly from within OJS without needing an email to be sent.
The text was updated successfully, but these errors were encountered: