Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add masthead option to user roles #9552

Closed
bozana opened this issue Dec 1, 2023 · 8 comments
Closed

Add masthead option to user roles #9552

bozana opened this issue Dec 1, 2023 · 8 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Dec 1, 2023

Implement the possibility for JM to define if a role should be considered and displayed on/in the masthead. This should be a further option in the add/edit role form.

PRs:

Add masthead attribute to the userGroups.dtd PR:

@bozana bozana self-assigned this Dec 1, 2023
@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Dec 1, 2023
@bozana bozana added this to the 3.5.0 LTS milestone Dec 1, 2023
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 9, 2024
bozana added a commit to bozana/omp that referenced this issue Jan 9, 2024
bozana added a commit to bozana/omp that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 9, 2024
@bozana
Copy link
Collaborator Author

bozana commented Jan 9, 2024

@asmecher, could you please review the PRs above?
Thanks a lot!

@asmecher
Copy link
Member

asmecher commented Jan 9, 2024

@bozana, looks good -- the plan is to allow individual registrations for a user group to override the user group's "default", right?

@bozana
Copy link
Collaborator Author

bozana commented Jan 9, 2024

Hi @asmecher, yes, I understand that the JII users will not have the possibility to change it on the invitation page, but the others will have that possibility, i.e. for the other there will be a possibility to define it on the user level, if a user will be considered for the masthead). Is this what you mean?

@asmecher
Copy link
Member

asmecher commented Jan 9, 2024

I am at risk of forgetting our thought process on this :) but I think it will not be uncommon for journals to want e.g. some editors listed on the masthead, others not. No matter how much everyone swears before we code it that this won't happen. :)

So the default role configuration for Editors should be masthead=true, as you've currently coded it 👍

...but...

When an invitation is sent, the user who creates it (typically the journal manager) should also have a checkbox for the masthead status (only showing for user groups with masthead=true) allowing them override it and hide certain enrolments. The user receiving the invitation maybe will be informed of it, but won't be able to change it.

@bozana
Copy link
Collaborator Author

bozana commented Jan 9, 2024

Yes, this is so. There will be a select box with "Appears on the Masthead" and "Does not appear in the Masthead", that JM can choose from for each users and role the user is invited in.
Hmmm... Maybe there should then also be the masthead select box on the user edit form, so that JM can change it later? (e.g. if users change their mind)... 🤔
But, for JII plugin users there will not be this possibility, as far as I understand.

@bozana
Copy link
Collaborator Author

bozana commented Jan 9, 2024

Ah, yes, correct. This is also on my list, the change of the user edit form according to the second image here: #9271 (comment). So yes, there will then also be the select box on the user edit form (except for the JII plugin users)... :-)
I will then merge this and proceed with the UIs next... :-)

@bozana
Copy link
Collaborator Author

bozana commented Jan 9, 2024

So actually, we would also need a masthead column in the user_user_groups table? 🤔

bozana added a commit to bozana/pkp-lib that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 9, 2024
bozana added a commit to bozana/omp that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 9, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 9, 2024
@asmecher
Copy link
Member

asmecher commented Jan 9, 2024

So actually, we would also need a masthead column in the user_user_groups table? 🤔

Yes, I think so!

bozana added a commit to bozana/omp that referenced this issue Jan 11, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 11, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 11, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 11, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 11, 2024
bozana added a commit to bozana/omp that referenced this issue Jan 11, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 11, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 14, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 14, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 14, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 14, 2024
bozana added a commit to bozana/omp that referenced this issue Jan 14, 2024
bozana added a commit to bozana/ojs that referenced this issue Jan 16, 2024
bozana added a commit to bozana/omp that referenced this issue Jan 16, 2024
bozana added a commit to bozana/omp that referenced this issue Jan 16, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 16, 2024
bozana added a commit to bozana/ops that referenced this issue Jan 16, 2024
bozana added a commit that referenced this issue Jan 17, 2024
#9552 add masthead option to user roles
bozana added a commit to pkp/ojs that referenced this issue Jan 17, 2024
pkp/pkp-lib#9552 add masthead option to user roles
bozana added a commit to pkp/omp that referenced this issue Jan 17, 2024
pkp/pkp-lib#9552 add masthead option to user roles
bozana added a commit to pkp/ops that referenced this issue Jan 17, 2024
pkp/pkp-lib#9552 add masthead option to user roles
@bozana bozana closed this as completed Jan 17, 2024
@bozana bozana mentioned this issue Jan 17, 2024
20 tasks
@bozana bozana mentioned this issue Feb 14, 2024
20 tasks
bozana added a commit to bozana/pkp-lib that referenced this issue Jun 24, 2024
bozana added a commit to bozana/ojs that referenced this issue Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
Status: Done
Development

No branches or pull requests

2 participants