Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate older Tables to newer Table API #9744

Closed
jardakotesovec opened this issue Feb 19, 2024 · 1 comment
Closed

Migrate older Tables to newer Table API #9744

jardakotesovec opened this issue Feb 19, 2024 · 1 comment
Assignees
@blesildaramirez
Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. UI/UX Issues affecting the user interface/user experience
Milestone
3.5.0 LTS

Comments

@jardakotesovec
Copy link
Contributor

jardakotesovec commented Feb 19, 2024 •
edited by blesildaramirez
Loading

Describe the issue
With new submissions listing it was necessary to introduce new Table component with more flexible API. New table is now covered in storybook. But there is couple of use cases using previous Table component.

Solution
Refactor older tables to use new API, should be relatively straightforward.

Pull requests:
pkp-lib/main: #10255 (merged)
ui-library/main: pkp/ui-library#389 (merged)
ojs/main: pkp/ojs#4378 (merged)
omp/main: pkp/omp#1656 (merged)
ops/main: pkp/ops#737 (merged)

Cleanup PRs:
pkp-lib/main: #10369 (merged)
ui-library/main: pkp/ui-library#407 (merged)
ojs/main: pkp/ojs#4427 (submodule updates only, closed)
omp/main: pkp/omp#1691 (submodule updates only, closed)
ops/main: pkp/ops#764 (submodule updates only, closed)
@jardakotesovec jardakotesovec added Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. UI/UX Issues affecting the user interface/user experience labels Feb 19, 2024
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone Feb 19, 2024
@jardakotesovec jardakotesovec self-assigned this Feb 19, 2024
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Jul 26, 2024
@blesildaramirez
pkp/pkp-lib#9744 Migrate old tables to use new table api (TableNext)
b3433fe
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Jul 26, 2024
@blesildaramirez
pkp/pkp-lib#9744 Copy table data mocks to TableNext component dir
a55fdb7
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Jul 26, 2024
@blesildaramirez
pkp/pkp-lib#9744 Use correct event handler when sorting table for Sta…
93e85c3 
…tsPage stories file
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Jul 26, 2024
@blesildaramirez
pkp#9744 Register components from new table api: TableNext
304ab71
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Jul 26, 2024
@blesildaramirez
pkp#9744 Migrate old tables to use new table api (TableNext)
894bf39
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Jul 26, 2024
@blesildaramirez
pkp/pkp-lib#9744 Migrate stats issues table to use new table component
7a2ea50
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Jul 26, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
4df84fe
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Jul 26, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
a532db2
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Jul 26, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
d7b2e84
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Jul 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Add missing classes for new table component
c0920bc
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Jul 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
16a7d5d
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Jul 29, 2024
@blesildaramirez
pkp#9744 Update cypress test when checking cell in failed jobs table
2e6561d
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Jul 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
1dcda10
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Jul 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
41b3ee8
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Jul 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
603dd8e
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Aug 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Migrate old tables to use new table api (TableNext)
76425d1
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Aug 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Copy table data mocks to TableNext component dir
0fa5f16
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Aug 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Use correct event handler when sorting table for Sta…
c101ef7 
…tsPage stories file
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Aug 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Add missing classes for new table component
a2a7595
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Aug 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Re-add missing tooltip in StatsPage story
390263f
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Aug 29, 2024
@blesildaramirez
pkp/pkp-lib#9744 Add top-controls and bottom-controls to new table co…
2262259 
…mponent
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Aug 30, 2024
@blesildaramirez
pkp/pkp-lib#9744 Add vue templates for Jobs, FailedJobs and FailedJob…
12837ce 
…Details pages
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Aug 30, 2024
@blesildaramirez
pkp#9744 Register components from new table api: TableNext
92d6191
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Sep 4, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
aedb7b8
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Sep 4, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
939a398
blesildaramirez added a commit to pkp/ui-library that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Migrate older Tables to newer Table API (#389)
b978d50 
* pkp/pkp-lib#9744 Migrate old tables to use new table api (TableNext)

* pkp/pkp-lib#9744 Copy table data mocks to TableNext component dir

* pkp/pkp-lib#9744 Use correct event handler when sorting table for StatsPage stories file

* pkp/pkp-lib#9744 Add missing classes for new table component

* pkp/pkp-lib#9744 Re-add missing tooltip in StatsPage story

* pkp/pkp-lib#9744 Add top-controls and bottom-controls to new table component

* pkp/pkp-lib#9744 Add vue templates for Jobs, FailedJobs and FailedJobDetails pages

* pkp/pkp-lib#9744 Add accessible attributes to DOI tables

* pkp/pkp-lib#9744 Add class attr to Table component

* pkp/pkp-lib#9744 Add slot for no-content for TableBody component

* pkp/pkp-lib#9744 Remove added pkpTable classes for TableRow and TableCell components

* pkp/pkp-lib#9744 Replace aria-label with labelled-by in StatsPage stories

* pkp/pkp-lib#9744 Remove unused FailedJobDetailsPage container and component imports

* pkp/pkp-lib#9744 Code cleanup on the table component and stats-page stories file

* pkp/pkp-lib#9744 Remove setting tableClasses in Stats pages

* pkp/pkp-lib#9744 Fix eslint problems

* pkp/pkp-lib#9744 Rename JobsPage container to JobsPageBase

* pkp/pkp-lib#9744 Move JobsPageBase to /pages/jobs dir

* pkp/pkp-lib#9744 Update how no-content slot is rendered in TableBody component
blesildaramirez added a commit that referenced this issue Sep 5, 2024
@blesildaramirez
#9744 Migrate older Tables to newer Table API (#10255)
0d8b72e 
* #9744 Register components from new table api: TableNext

* #9744 Migrate old tables to use new table api (TableNext)

* #9744 Update cypress test when checking cell in failed jobs table

* #9744 Migrate jobs, failed jobs and failed-jobs-page from smarty to vue templates

* #9744 Add labelled-by attribute when using PkpTable for stats pages

* #9744 Use no-content slot when showing no items for Table component - stats pages

* #9744 Fix issue with Editorial stats table column width

* #9744 Update cypress test for checking the author cell on the publication stats table

* #9744 Code cleanup on stats/editorial template

* #9744 Remove tableClass -isLoading (setting opacity) when table is loading

* #9744 Add Pkp prefix when registering table components

* #9744 Rename table component used on stats template files

* #9744 Remove table-row and table-cell when passing slot to TableBody component

* #9744 Remove class added for stats editorial template
blesildaramirez added a commit to pkp/ojs that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 [OJS] Migrate older Tables to newer Table API (#4378)
a47fddd 
* pkp/pkp-lib#9744 Migrate stats issues table to use new table component

* pkp/pkp-lib#9744 Inject new pages for jobs, failed jobs and failed job details pages

* pkp/pkp-lib#9744 Update issues.tpl to add labelled-by and no-content slot for Table component

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##

* pkp/pkp-lib#9744 Remove registration of pages components as they are imported by parent component - Page.vue

* pkp/pkp-lib#9744 Update table component names in issues template

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##

* pkp/pkp-lib#9744 Rename use of table components from stats issues template file

* pkp/pkp-lib#9744 Remove table-row and table-cell when passing slot to TableBody component

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
blesildaramirez added a commit to pkp/omp that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744## (#1656)
8f44c52 
* pkp/pkp-lib#9744 Update import of JobsPage, FailedJobsPage and FailedJobDetailsPage components

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##

* pkp/pkp-lib#9744 Remove registration of pages components as they are imported by parent component - Page.vue

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
blesildaramirez added a commit to pkp/ops that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744## (#737)
58aeec8 
* pkp/pkp-lib#9744 Update imports for JobsPage, FailedJobsPage, FailedJobDetailsPage components

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##

* pkp/pkp-lib#9744 Remove registration of pages components as they are imported by parent component - Page.vue

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##

* pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Sep 5, 2024
@blesildaramirez
pkp#9744 Update imports of table components
35691e1
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Delete old Table component
7469283
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Rename TableNext component to Table
e5a903e
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
72eac37
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
5d44196
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
c2ac795
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Sep 5, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
5b623f1
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Sep 9, 2024
@blesildaramirez
pkp/pkp-lib#9744 Change how aria-labelledby and aria-describedby is a…
54f04a0 
…ssigned in the table
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Sep 9, 2024
@blesildaramirez
pkp/pkp-lib#9744 Update documentation for Table component
661a912
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Sep 10, 2024
@blesildaramirez
pkp#9744 Update imports of table components
00ade95
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Sep 10, 2024
@blesildaramirez
pkp#9744 Migrate native tables to new table component
71f7059
blesildaramirez added a commit to blesildaramirez/pkp-lib that referenced this issue Sep 10, 2024
@blesildaramirez
pkp#9744 Update cypress test query selector for jobs page tests
7135244
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Sep 10, 2024
@blesildaramirez
pkp/pkp-lib#9744 Migrate native tables that use class pkpTable to use…
0d2198b 
… the new table component
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Sep 10, 2024
@blesildaramirez
pkp/pkp-lib#9744 Update logic of noContent in TableBody component
07e4bbc
blesildaramirez added a commit to blesildaramirez/ui-library that referenced this issue Sep 10, 2024
@blesildaramirez
pkp/pkp-lib#9744 Remove unused classes related to table component
b78aefb
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Sep 10, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
4566c7d
blesildaramirez added a commit to blesildaramirez/omp that referenced this issue Sep 10, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
6fda78b
blesildaramirez added a commit to blesildaramirez/ops that referenced this issue Sep 10, 2024
@blesildaramirez
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
d45a846
blesildaramirez added a commit to pkp/ui-library that referenced this issue Sep 12, 2024
@blesildaramirez
pkp/pkp-lib#9744 Rename the "TableNext" component to "Table" and migr…
7cd7278 
…ate native tables with class "pkpTable" (#407)

* pkp/pkp-lib#9744 Delete old Table component

* pkp/pkp-lib#9744 Rename TableNext component to Table

* pkp/pkp-lib#9744 Change how aria-labelledby and aria-describedby is assigned in the table

* pkp/pkp-lib#9744 Update documentation for Table component

* pkp/pkp-lib#9744 Migrate native tables that use class pkpTable to use the new table component

* pkp/pkp-lib#9744 Update logic of noContent in TableBody component

* pkp/pkp-lib#9744 Remove unused classes related to table component
blesildaramirez added a commit that referenced this issue Sep 12, 2024
@blesildaramirez
#9744 Update the imports of the "TableNext" component to the newly re…
f2f64dd 
…named "Table" and migrate native tables with class "pkpTable" (#10369)

* #9744 Update imports of table components

* #9744 Migrate native tables to new table component

* #9744 Update cypress test query selector for jobs page tests
@blesildaramirez blesildaramirez mentioned this issue Sep 18, 2024
Open
@blesildaramirez
Copy link
Contributor

Raised a separate issue to address one more table to be migrated to use new table component: #10443 [URNPubIdPlugin]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blesildaramirez blesildaramirez

Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. UI/UX Issues affecting the user interface/user experience
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@jardakotesovec @blesildaramirez