Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Laravel version 11.x #9892

Closed
touhidurabir opened this issue Apr 17, 2024 · 11 comments
Closed

Upgrade to Laravel version 11.x #9892

touhidurabir opened this issue Apr 17, 2024 · 11 comments
Assignees
@touhidurabir @pkp-dev-infrastructure
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5.0 LTS

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Apr 17, 2024 •
edited
Loading

Describe the Proposal
With the intension to make the release of 3.5.0 a LTS, we should aim to have all the dependencies updated as much as possible . The current main(pre release of 3.5.0) now have Laravel 10.x as the dependency which will be get bug fix till August 6th, 2024 . Also by the time the 3.5.0 get to release it will be an older version of laravel . Better to upgrade the laravel version to 11.x .

Additional Information
With the release of stable laravel version 11.x at March 12th, 2024 which seems like a more of better candidate for next LTS release as it will have a longer support period, more details at https://laravel.com/docs/11.x/releases#support-policy . The most important requirement for it is PHP 8.2+ which is also seems like a good opportunity to ship the next LTS with more actively supported PHP version as PHP 8.1 will be at the end of active support by next release, more details at https://www.php.net/supported-versions.php .

The upgrade process and details does not seems to contains many high impact changes and most of those seems to be resolvable with less effort, more details at https://laravel.com/docs/11.x/upgrade .

PRs
pkp-lib --> #10211
ojs --> pkp/ojs#4367
omp --> pkp/omp#1669
ops --> pkp/ops#748
@touhidurabir touhidurabir added this to the 3.5.0 LTS milestone Apr 17, 2024
@touhidurabir touhidurabir added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Apr 17, 2024
@asmecher
Copy link
Member

@touhidurabir, I checked with the Technical Committee, and they didn't raise any problems with bumping our PHP base to 8.2 for OJS/OMP/OPS 3.5. They're primarily familiar with RHEL (EPEL) and Debian/Ubuntu.

@touhidurabir touhidurabir self-assigned this Jul 15, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 16, 2024
@touhidurabir
pkp#9892 Dependency updated and auth configured
dbf43ba
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 16, 2024
@touhidurabir
pkp#9892 Dependency updated and auth configured
4a44144
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 16, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
6c311e4
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 16, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
fced965
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 16, 2024
@touhidurabir
pkp#9892 DB float type precision added
d3335dc
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 16, 2024
@touhidurabir
pkp#9892 removed doctrine/dbal package dependency
dd7b71b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 16, 2024
@touhidurabir
pkp/pkp-lib#9892 DB float type precision added
f822425
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 16, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
adf40bf
This was referenced Jul 16, 2024
Merged
Merged
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 16, 2024
@touhidurabir
pkp#9892 downgraded wikimedia/less.php from 5.* to 4.*
f795efe
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 16, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
13979e4
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 16, 2024
@touhidurabir
pkp#9892 downgraded wikimedia/less.php from 4.* to 3.*
a158778
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 upgraded wikimedia/less.php to 5.*
1994e9d
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 17, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
78aac67
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 17, 2024
@touhidurabir
pkp/pkp-lib#9892 updated paypal plugin composer dependency
40046a6
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 17, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
ccec69a
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 Dependency updated and auth configured
316af48
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 DB float type precision added
da6ae4a
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 removed doctrine/dbal package dependency
1ddd20a
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 downgraded wikimedia/less.php from 5.* to 4.*
7dc1d06
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 downgraded wikimedia/less.php from 4.* to 3.*
106464e
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 upgraded wikimedia/less.php to 5.*
e3437f3
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 17, 2024
@touhidurabir
pkp#9892 packages upgrade
9e6c5a1
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 17, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
56b6f6d
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 12, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
e5f69e0
@touhidurabir touhidurabir mentioned this issue Aug 12, 2024
Merged
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 12, 2024
@touhidurabir
pkp/pkp-lib#9892 fixing broken unit test
e5ccaa2
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 12, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
8e561bf
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 12, 2024
@touhidurabir
pkp/pkp-lib#9892 fixed deprecated tests method
55947a0
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 12, 2024
@touhidurabir
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
db1398a
@touhidurabir
Copy link
Member Author

@asmecher All tests are passing and resolved all pointed reviews at #10211 (review) . Just one query to review at pkp/omp#1669 (comment) . If all ok, should be good to merge .

asmecher pushed a commit that referenced this issue Aug 12, 2024
@touhidurabir
#9892 upgrade to laravel 11 and PHP 8.2+ (#10211)
cbf8b01 
* #9892 Dependency updated and auth configured

* #9892 DB float type precision added

* #9892 removed doctrine/dbal package dependency

* #9892 downgraded wikimedia/less.php from 5.* to 4.*

* #9892 downgraded wikimedia/less.php from 4.* to 3.*

* #9892 upgraded wikimedia/less.php to 5.*

* #9892 packages upgrade

* #9892 PKP required version updated

* #9892 removed reference of psr6 cache interface

* #9892 PHPUnit 11 compatibility test

* #9892 updated PHPUnit command

* #9892 updated packages after rebase

* #9892 PHPUnit 11 doc block to attributes convert to update deprecations

* #9892 PHPUnit command update to make compatibale with version 11

* #9892 WIP: MariaDB driver compatibility

* #9892 WIP: MariaDB driver compatibility

* #9892 fixed column types

* #9892 maria db driver name update

* #9892 db driver determining issue fixing

* #9892 WIP: db driver determining issue fixing

* #9892 PHP 8.2 compatibility checks

* #9892 fixed broken test

* #9892 fixing failing tests

* #9892 removing Doctrine DBAL related method usage

* #9892 logging upgrade exception

* #9892 removed test logging upgrade exception

* #9892 moved the foreign key check form trait to core pkp migration class

* #9892 add missing namespace
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
897f3ed
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 DB float type precision added
c601379
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 updated paypal plugin composer dependency
e483ae3
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 PHPUnit 11 doc block to attributes convert to update…
5d6786e 
… deprecations
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 WIP: MariaDB driver compatibility
7e512e4
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 fixed column types and added float to decimal change…
599452b 
… migration
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 fixing failing tests
e8ee025
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 removing Doctrine DBAL related method usage
b510b96
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 added missing upgrade migration
76a1c7d
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 moved the foreign key check form trait to core pkp m…
012760c 
…igration class
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 fixed deprecated tests method
3efc6b6
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
799cc73
asmecher pushed a commit to pkp/omp that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 upgrade to laravel 11 and PHP 8.2+
ab71e85
asmecher pushed a commit to pkp/omp that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
85a3ce3
asmecher pushed a commit to pkp/omp that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 fixing broken unit test
fb72f7c
asmecher pushed a commit to pkp/omp that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
22a059b
asmecher pushed a commit to pkp/ops that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 upgrade to laravel 11 and PHP 8.2+
fc34c9f
asmecher pushed a commit to pkp/ops that referenced this issue Aug 12, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9892 Submodule Update ##touhidurabir/i9892_main##
4d795d3
@asmecher
Copy link
Member

All merged -- thanks, @touhidurabir!

@touhidurabir
Copy link
Member Author

@asmecher do you think anything more required for this ? may be some plugins ?

@asmecher
Copy link
Member

Nothing off the top of my head -- but I'll keep an eye out. Closing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

@pkp-dev-infrastructure pkp-dev-infrastructure

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
3 participants
@asmecher @touhidurabir @pkp-dev-infrastructure