Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMP] Add support for submission keyword metadata in ONIX extract #9894

Closed
asmecher opened this issue Apr 17, 2024 · 5 comments
Closed

[OMP] Add support for submission keyword metadata in ONIX extract #9894

asmecher opened this issue Apr 17, 2024 · 5 comments
Assignees
Milestone

Comments

@asmecher
Copy link
Member

Describe the bug
The ONIX extract doesn't currently include submission keyword metadata. From DOAB:

Please use DescriptiveDetail/Subject[SubjectSchemeIdentifier=20]/SubjectHeadingText or else DescriptiveDetail/Subject[SubjectSchemeIdentifier=04]/SubjectCode

@kaitlinnewson
Copy link
Member

kaitlinnewson commented Jun 21, 2024

@asmecher This is ready for an initial review.

I noticed that currently the subjects are being pulled from all locales and combined together, so I changed that so it's only pulling in subjects from the publication's primary locale.

@asmecher
Copy link
Member Author

Thanks, @kaitlinnewson, I merged the PR. But just to confirm: you found documentation about ONIX with guidance about multilingual content, right? Could you link that here?

@kaitlinnewson
Copy link
Member

Here's the documentation on multilingual metadata in Onix.

@kaitlinnewson
Copy link
Member

@asmecher Additional ported PRs are linked above and ready for review.

@asmecher
Copy link
Member Author

All merged, thanks! Closing.

@github-project-automation github-project-automation bot moved this from In Progress to Done in DOAB / OMP Data Exchange Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants