Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pimple with laravel's dependency injection container #9913

Closed
touhidurabir opened this issue Apr 25, 2024 · 6 comments
Closed

Replace pimple with laravel's dependency injection container #9913

touhidurabir opened this issue Apr 25, 2024 · 6 comments
Assignees
@touhidurabir @pkp-dev-infrastructure
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5 Internal

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Apr 25, 2024 •
edited
Loading

Describe the proposal
There are some implementations in the codebase that use the Pimple for the purpose of dependency injection. This package is a part of micro framework Silex which as been deprecated quite some times ago. Also as we have laravel's own dependency injection container, it's better to use that as we are adopting more from laravel's toolset .

What application are you using?
OJS, OMP or OPS version main (3.5.0 pre release)

Additional information
Only few classes are using it such as

  1. PKP\core\PKPServices
  2. APP\core\Services
  3. APP\services\OJSServiceProvider
  4. APP\services\OMPServiceProvider
  5. APP\services\OPSServiceProvider

Probably a good approach is to utilize the app or shared lib(pkp-lib) specific AppServiceProvider to put the functionalities there .

PRs
pkp-lib --> #10177
ojs --> pkp/ojs#4358
omp --> pkp/omp#1633
ops --> pkp/ops#728
crossref-ojs --> pkp/crossref-ojs#51
jatsTemplate --> pkp/jatsTemplate#45
oaiJats --> pkp/oaiJats#45
plagiarism --> pkp/plagiarism#61
crossref-ops --> pkp/crossref-ops#41
@touhidurabir touhidurabir added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Apr 25, 2024
@jonasraoni
Copy link
Contributor

I think this can be closed as a duplicate of #7131

@touhidurabir touhidurabir added this to the 3.5 Internal milestone Jul 9, 2024
@touhidurabir touhidurabir self-assigned this Jul 9, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 9, 2024
@touhidurabir
pkp#9913 Removed pimple container dependency
428fd0c
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 9, 2024
@touhidurabir
pkp/pkp-lib#9913 Removed pimple container dependency
fe14da3
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 9, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
1940384
This was referenced Jul 9, 2024
Merged
Merged
@touhidurabir
Copy link
Member Author

@asmecher can you check the PRs at #9913 (comment). This simple PRs centralize all services to use the laravel container and remove pimple container . If all ok, I plan to remove all reference of Services::get with app()->get() and port it to OMP and OPS .

@asmecher
Copy link
Member

Looks good, @touhidurabir, please go ahead! Also document any code changes that might be necessary for 3rd parties in the top comment, and add a link to it in #9276.

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 removed pimple reference from build package script
b1a2e09
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 11, 2024
@touhidurabir
pkp#9913 removed usage of Services::get and related namespaces
b6d31af
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 removed usage of Services::get and related namespaces
061d17a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
ab536cb
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 11, 2024
@touhidurabir
pkp#9913 Removed pimple container dependency
359467e
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jul 11, 2024
@touhidurabir
pkp#9913 removed usage of Services::get and related namespaces
67d62e3
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
c5aa676
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 Removed pimple container dependency
90f75dd
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
8b18683
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 removed pimple reference from build package script
0a18413
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 removed usage of Services::get and related namespaces
6a1cc0c
touhidurabir added a commit to touhidurabir/omp that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 removed pimple dependency
1aab55e
touhidurabir added a commit to touhidurabir/omp that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
e709953
@touhidurabir touhidurabir mentioned this issue Jul 11, 2024
Merged
touhidurabir added a commit to touhidurabir/ops that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 removed pimple dependency
eb3c224
touhidurabir added a commit to touhidurabir/ops that referenced this issue Jul 11, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
cf7c9fc
This was referenced Jul 11, 2024
Merged
Open
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 1, 2024
@touhidurabir
pkp#9913 removed usage of Services::get and related namespaces
475b8be
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 1, 2024
@touhidurabir
pkp#9913 removed Services::get reference from older upgrade migrations
86d9fe1
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
6d50162
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 Removed pimple container dependency
5a08000
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
0afc8c0
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 removed pimple reference from build package script
e30ae9a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 removed usage of Services::get and related namespaces
379aef9
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
d4c3d99
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 removed pimple dependency
652b4c4
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
2523db9
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
00f7374
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 removed pimple dependency
acb7fcc
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
edbcbd0
@touhidurabir
Copy link
Member Author

@asmecher

  1. rebased
  2. all tests are passing for OJS, OMP and OPS .
  3. Only plagiarism had missing stable-3_4_0 branch and I have created it from main .

it's ready for merge but I do not have write access to few plugins repo . Can you please merge it as it's better to have all merged at same time to avoid conflict .

asmecher pushed a commit that referenced this issue Aug 1, 2024
@touhidurabir
#9913 Removed pimple container dependency (#10177)
4c31a12 
* #9913 Removed pimple container dependency

* #9913 removed usage of Services::get and related namespaces

* #9913 removed Services::get reference from older upgrade migrations
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 Removed pimple container dependency
10629b2
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
54df8f4
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 removed pimple reference from build package script
47dc74c
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 removed usage of Services::get and related namespaces
3737e45
asmecher pushed a commit to pkp/omp that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 removed pimple dependency
18130b0
asmecher pushed a commit to pkp/omp that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
e3e2690
asmecher pushed a commit to pkp/ops that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 removed pimple dependency
340b86b
asmecher pushed a commit to pkp/ops that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 Submodule Update ##touhidurabir/i9913_main##
574df45
asmecher added a commit to pkp/crossref-ojs that referenced this issue Aug 1, 2024
@asmecher
Merge pull request #51 from touhidurabir/i9913_main
c1dab41 
pkp/pkp-lib#9913 replaced depreciated Services::get with app()->get
asmecher pushed a commit to pkp/jatsTemplate that referenced this issue Aug 1, 2024
@touhidurabir @asmecher
pkp/pkp-lib#9913 replaced depreciated Services::get with app()->get
45373b2
asmecher pushed a commit to pkp/oaiJats that referenced this issue Aug 1, 2024
@touhidurabir
pkp/pkp-lib#9913 replaced depreciated Services::get with app()->get (#45
6e31fc3 
)
asmecher added a commit to pkp/plagiarism that referenced this issue Aug 1, 2024
@asmecher
Merge pull request #61 from touhidurabir/i9913_main
b531344 
pkp/pkp-lib#9913 replaced depreciated Services::get with app()->get
asmecher added a commit to pkp/crossref-ops that referenced this issue Aug 1, 2024
@asmecher
Merge pull request #41 from touhidurabir/i9913_main
9bb577c 
pkp/pkp-lib#9913 replaced depreciated Services::get with app()->get
@asmecher
Copy link
Member

asmecher commented Aug 1, 2024

All merged, thanks! Closing.

@asmecher asmecher closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

@pkp-dev-infrastructure pkp-dev-infrastructure

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
4 participants
@asmecher @jonasraoni @touhidurabir @pkp-dev-infrastructure