Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check phpunit version for RouterTest #10022

Closed
wants to merge 1 commit into from
Closed

Check phpunit version for RouterTest #10022

wants to merge 1 commit into from

Conversation

withanage
Copy link
Member

No description provided.

@withanage withanage requested a review from asmecher June 7, 2024 13:25
@withanage
Copy link
Member Author

Hi @asmecher ,

This PR chcecks for phpunit version for version 3.3 , php errors

@withanage
Copy link
Member Author

Related

This was referenced Jun 7, 2024
Merged
Merged
asmecher
asmecher reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we specify the phpunit version in Composer, I don't think we need to support multiple versions.

@withanage
Copy link
Member Author

@asmecher thanks! closing without merged, cause it can be solved by setting php ini values explicitly for phpunit

@withanage withanage closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher asmecher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@withanage @asmecher