Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update theme plugins for 3.4 #302

Closed
wants to merge 1 commit into from

Conversation

kaitlinnewson
Copy link
Member

Update theme plugins:

  • Classic
  • Health Sciences
  • Immersion
  • Pragma

@kaitlinnewson
Copy link
Member Author

@asmecher Ready for a review

@asmecher
Copy link
Member

Thanks, @kaitlinnewson! The plugin validation tool only expects one new plugin per PR (another thing that could be improved), so it only validated classic. Could you split this into several PRs, one per plugin?

Also, I suspect it's only cosmetic, but I do see a bunch of warnings in the extraction part of the test:

tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.quarantine'
tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.provenance'

This appears to be due to differences between BST tar and GNU tar; it might be worth using GNU tar on your system to build plugins. On the extraction side, adding --warning=no-unknown-keyword seems to silence it, but I'd hate to start spreading that around everywhere in case it has knock-on effects.

@kaitlinnewson
Copy link
Member Author

@asmecher new PRs created and I've recreated the release packages using GNU tar.

@asmecher
Copy link
Member

All merged, thanks, @kaitlinnewson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants