⬆️ Bump 9c-headless #515
Merged
⬆️ Bump 9c-headless #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riemannulus
reviewed
Oct 17, 2023
|
|
||
| int raidId = 0; | ||
| bool found = false; | ||
| for (int i = 0; i < 99; i++) | ||
| { | ||
| if (ev.OutputState.Delta.UpdatedAddresses.Contains( | ||
| if (outputState.Delta.UpdatedAddresses.Contains( |
There was a problem hiding this comment.
Does it contain real Delta.UpdatedAddresses? Don't we need ITrie.Diff() in this case?
There was a problem hiding this comment.
See 9aa4c9e.
- Possibly a lot slower than before.
- Behavior might not be the same as diff of
ITrieonly searches for actual changed value.
greymistcube
force-pushed
the
bump/9c-headless
branch
from
272819d to
4e01f3b
Compare
area363
approved these changes
Oct 17, 2023
riemannulus
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️