Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/72 to main #561

Merged
merged 58 commits into from
Nov 21, 2023
Merged

Release/72 to main #561

merged 58 commits into from
Nov 21, 2023

Conversation

area363
Copy link
Member

@area363 area363 commented Nov 21, 2023

SSIA

area363 and others added 30 commits November 7, 2023 18:40
…s.Headless@7cf5465

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--5629638

Update NineChronicles.Headless to release/72
…s.Headless@b1d0dfb

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--f2fde2c

Update NineChronicles.Headless to release/72
…s.Headless@187ab1d

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--ac31161

Update NineChronicles.Headless to release/72
…s.Headless@c142fff

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--f74af93

Update NineChronicles.Headless to release/72
…s.Headless@5260823

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--6bbf855

Update NineChronicles.Headless to release/72
…s.Headless@8d73d90

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--2f62d6d

Update NineChronicles.Headless to release/72
…s.Headless@5b8a840

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--ff46efc

Update NineChronicles.Headless to release/72
…s.Headless@b7f5531

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--497ff00

Update NineChronicles.Headless to release/72
install `.NET6` compatible dotnet-ef tool
…s.Headless@c922947

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--da8a943

Update NineChronicles.Headless to release/72
area363 and others added 27 commits November 17, 2023 16:06
…odule-update/NineChronicles.Headless/release/72--485c066

Update NineChronicles.Headless to release/72
…s.Headless@e54343b

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--68c8463

Update NineChronicles.Headless to release/72
…s.Headless@78f46e7

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--5c95f2e

Update NineChronicles.Headless to release/72
…s.Headless@364ee67

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--d11886c

Update NineChronicles.Headless to release/72
…s.Headless@c627a44

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--a428ca5

Update NineChronicles.Headless to release/72
…s.Headless@b952200

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--6d378ef

Update NineChronicles.Headless to release/72
…s.Headless@78e9be3

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--9a5e6c3

Update NineChronicles.Headless to release/72
…s.Headless@1fdd655

This commit was automatically generated by Submodule Updater.
…odule-update/NineChronicles.Headless/release/72--25e167c

Update NineChronicles.Headless to release/72

This PR has 697 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +690 -7
Percentile : 89.9%

Total files changed: 40

Change summary by file extension:
.amd64 : +1 -1
.arm64v8 : +1 -1
.cs : +316 -3
.Headless : +1 -1
.sql : +370 -0
Dockerfile : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@area363 area363 merged commit e54c857 into planetarium:main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants