Separate create and stage tx #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate create tx and stage tx
- Create transactions first and save
- Then stage it after
- This prevents delivery duplication casud by DB save missing
ipdae
previously approved these changes
Dec 13, 2024
| @@ -16,7 +16,7 @@ def create_unsigned_tx(planet_id: PlanetID, public_key: str, address: str, nonce | |||
| # Genesis block hash | |||
| b"g": get_genesis_block_hash(planet_id), | |||
| # GasLimit (see also GasLimit list section below) | |||
| b"l": 1, | |||
| b"l": 4, | |||
There was a problem hiding this comment.
가스비는 왜 4로 올라간건가요? transfer_asset을 호출하나요?
There was a problem hiding this comment.
가끔 manual 로 다른 계정(SeasonPass 라던지) 으로 TransferAssets를 할 일이 있어서 limit 를 올려두었습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent delivery duplication
resolves #356