Merge pull request #1725 from planetary-social/bdm/list-localization

localized strings on the feed filter drop-down view
planetary-social · Jan 8, 2025 · 33cfcea · 33cfcea
2 parents b8eca9d + 2734c26
commit 33cfcea
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,12 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 ### Release Notes
-
 - Fixed: adding/removing relays not reflected on feed filter. [#119](https://github.com/verse-pbc/issues/issues/119)
 
 ### Internal Changes
-
 - Added function for creating a new list and a test verifying list editing. [#112](https://github.com/verse-pbc/issues/issues/112)
+- Localized strings on the feed filter drop-down view.
 
 ## [1.1] - 2025-01-03Z
 

diff --git a/Nos/Assets/Localization/Localizable.xcstrings b/Nos/Assets/Localization/Localizable.xcstrings
@@ -922,6 +922,17 @@
         }
       }
     },
+    "addListsDescription" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Add lists to your feed to filter by topic."
+          }
+        }
+      }
+    },
     "addRelay" : {
       "extractionState" : "manual",
       "localizations" : {
@@ -10412,6 +10423,17 @@
         }
       }
     },
+    "lists" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Lists"
+          }
+        }
+      }
+    },
     "loading" : {
       "extractionState" : "manual",
       "localizations" : {
@@ -12403,6 +12425,17 @@
         }
       }
     },
+    "noLists" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "It doesn’t look like you have created any lists."
+          }
+        }
+      }
+    },
     "noNotifications" : {
       "extractionState" : "manual",
       "localizations" : {
@@ -12492,6 +12525,17 @@
         }
       }
     },
+    "noRelays" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "It doesn’t look like you have any relays."
+          }
+        }
+      }
+    },
     "noRelaysMessage" : {
       "extractionState" : "manual",
       "localizations" : {
@@ -16789,6 +16833,17 @@
         }
       }
     },
+    "selectRelaysDescription" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Select relays to show on your feed."
+          }
+        }
+      }
+    },
     "send" : {
       "extractionState" : "manual",
       "localizations" : {

diff --git a/Nos/Views/Home/FeedCustomizerView.swift b/Nos/Views/Home/FeedCustomizerView.swift
@@ -13,9 +13,9 @@ extension FeedTab: NosSegmentedPickerItem {
     var titleKey: LocalizedStringKey {
         switch self {
         case .lists:
-            "Lists"
+            "lists"
         case .relays:
-            "Relays"
+            "relays"
         }
     }
 
@@ -49,7 +49,7 @@ struct FeedCustomizerView: View {
             if selectedTab == .lists {
                 FeedSourceToggleView(
                     author: author,
-                    headerText: Text("Add lists to your feed to filter by topic."),
+                    headerText: Text("addListsDescription"),
                     items: feedController.listRowItems,
                     footer: {
                         Group {
@@ -67,18 +67,18 @@ struct FeedCustomizerView: View {
                         }
                     },
                     noContent: {
-                        Text("It doesn’t look like you have created any lists.")    // TODO: localize
+                        Text("noLists")
                     }
                 )
             } else {
                 FeedSourceToggleView(
                     author: author,
-                    headerText: Text("Select relays to show on your feed."),    // TODO: localize
+                    headerText: Text("selectRelaysDescription"),
                     items: feedController.relayRowItems,
                     footer: {
                         Group {
                             Text("Manage these on the ") +
-                            (Text("Relays")
+                            (Text("relays")
                                 .foregroundStyle(Color.accent)) +
                             Text(" screen")
                         }
@@ -88,7 +88,7 @@ struct FeedCustomizerView: View {
                         }
                     },
                     noContent: {
-                        Text("It doesn’t look like you have any relays.")   // TODO: localize
+                        Text("noRelays")
                     }
                 )
             }