added pop-up tip for feed customization #101 #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
requested review from
mplorentz,
joshuatbrown and
pelumy
as code owners
|
I wish TipKit would just allow enough customization... |
|
I know. So frustrating. You actually can style the popover tips using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
https://github.com/verse-pbc/issues/issues/101
Description
Added a custom pop-up tooltip view for feed customization.
Unfortunately, I wasn't able to use TipKit for this because currently you cannot fully style popover tips from TipKit. There is something called
TipViewStylethat you can use to get close, but the little triangle that's part of the tip cannot be styled in iOS 17/18 in SwiftUI. Reference: https://forums.developer.apple.com/forums/thread/742107So this is a custom implementation. I was reluctant to do this, and I'm still not 100% confident that we want to go this route, because it is a bit hacky and will require more maintenance than a TipKit solution would.
Tooltip shows up when user scrolls a couple screen-lengths down (before 30 seconds has passed):
