Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localized strings on the feed filter drop-down view #1725

Merged
merged 2 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Release Notes

- Fixed: adding/removing relays not reflected on feed filter. [#119](https://github.com/verse-pbc/issues/issues/119)

### Internal Changes

- Added function for creating a new list and a test verifying list editing. [#112](https://github.com/verse-pbc/issues/issues/112)
- Localized strings on the feed filter drop-down view.

## [1.1] - 2025-01-03Z

Expand Down
55 changes: 55 additions & 0 deletions Nos/Assets/Localization/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,17 @@
}
}
},
"addListsDescription" : {
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Add lists to your feed to filter by topic."
}
}
}
},
"addRelay" : {
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -10412,6 +10423,17 @@
}
}
},
"lists" : {
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Lists"
}
}
}
},
"loading" : {
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -12403,6 +12425,17 @@
}
}
},
"noLists" : {
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "It doesn’t look like you have created any lists."
}
}
}
},
"noNotifications" : {
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -12492,6 +12525,17 @@
}
}
},
"noRelays" : {
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "It doesn’t look like you have any relays."
}
}
}
},
"noRelaysMessage" : {
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -16789,6 +16833,17 @@
}
}
},
"selectRelaysDescription" : {
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Select relays to show on your feed."
}
}
}
},
"send" : {
"extractionState" : "manual",
"localizations" : {
Expand Down
14 changes: 7 additions & 7 deletions Nos/Views/Home/FeedCustomizerView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ extension FeedTab: NosSegmentedPickerItem {
var titleKey: LocalizedStringKey {
switch self {
case .lists:
"Lists"
"lists"
case .relays:
"Relays"
"relays"
}
}

Expand Down Expand Up @@ -49,7 +49,7 @@ struct FeedCustomizerView: View {
if selectedTab == .lists {
FeedSourceToggleView(
author: author,
headerText: Text("Add lists to your feed to filter by topic."),
headerText: Text("addListsDescription"),
items: feedController.listRowItems,
footer: {
Group {
Expand All @@ -67,18 +67,18 @@ struct FeedCustomizerView: View {
}
},
noContent: {
Text("It doesn’t look like you have created any lists.") // TODO: localize
Text("noLists")
}
)
} else {
FeedSourceToggleView(
author: author,
headerText: Text("Select relays to show on your feed."), // TODO: localize
headerText: Text("selectRelaysDescription"),
items: feedController.relayRowItems,
footer: {
Group {
Text("Manage these on the ") +
(Text("Relays")
(Text("relays")
.foregroundStyle(Color.accent)) +
Text(" screen")
}
Expand All @@ -88,7 +88,7 @@ struct FeedCustomizerView: View {
}
},
noContent: {
Text("It doesn’t look like you have any relays.") // TODO: localize
Text("noRelays")
}
)
}
Expand Down
Loading