Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update_merge.bat #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkoelewijn
Copy link
Contributor

Update update_merge.bat to use the new structure of the testset files

@jcassee
Copy link
Collaborator

jcassee commented Aug 29, 2013

My intention is to supersede update_merge.bat with the merge-gtfs command that is installed when running pip install -e . (or pip install -r dev_requirements.txt). What does update_merge.bat do that gtfs-merge does not?

@jkoelewijn
Copy link
Contributor Author

update_merge.bat first creates new zip files for the individual tests (which gtfs-merge probably does not) and finally merges the zip files together to form a alltests.zip. It uses onebusaway-gtfs-transformer-cli.jar to do that now.

@jcassee
Copy link
Collaborator

jcassee commented Aug 29, 2013

Alright, so what is missing from gtfs-merge that will make update_merge.bat superfluous? Probably just the last step of building the ZIP archive?

@jkoelewijn
Copy link
Contributor Author

I don't know what gtfs-merge is capable of. The output of update_merge.bat is all tests zipped individually and one alltests.zip.

@jcassee
Copy link
Collaborator

jcassee commented Aug 29, 2013

The merge-gtfs command will create a merged GTFS feed directory. I know what update_merge.bat does, but which of these archives do you need?

@jkoelewijn
Copy link
Contributor Author

In the end only alltests.zip. The individual zips were usefull when trying to get the individual tests to pass (because of depencies between tests, for example with the preferred transfers that make all transfers in other tests unpreferred). But if there's a script that can be used to build a fresh alltests.zip on Windows, then feel free to remove update_merge.bat.

@jcassee
Copy link
Collaborator

jcassee commented Aug 29, 2013

Currently merge-gtfs will only create the merged feed directory, but I will add an option to create the ZIP archive as well. Please stand by. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants