Enhance solution formatting and cleanup post Rider 2023.2.3 upgrade #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errc into WebApp folder
…m GitHub workflow
…of built-in Full Cleanup
tjementum
force-pushed
the
formatting
branch
2 times, most recently
from
1265654 to
5818597
Compare
tjementum
force-pushed
the
formatting
branch
from
5818597 to
5cdbe04
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Perform a cleanup across the entire solution following the upgrade to Rider 2023.2.3. Move JetBrains formatting rules from
.editorconfigto a.DotSettingsfile. This change enforces JetBrains formatting out-of-the-box and offers more granular control.Add a
.NET onlycleanup profile to.DotSettingsto prevent ReSharper and Rider from formatting frontend files. To maintain consistent formatting in frontend files, "Format on Save" should be manually configured to use Prettier. Additionally, file types such as.html,.css, and.jsonneed to be added to Prettier's configuration for comprehensive coverage.Furthermore, .NET tools, including the JetBrains inspectcode and cleanupcode formatter, have been added to
dotnet-tools.json. This inclusion streamlines tool management and ensures consistency across development environments. The GitHub workflow has been correspondingly updated to reflect these tooling changes, enhancing the efficiency and reliability of our continuous integration process.Build will now fail if there are any formatting or code inspection warnings.
Checklist