Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Aspire service orchestration #224

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Add .NET Aspire service orchestration #224

merged 8 commits into from
Nov 21, 2023

Conversation

tjementum
Copy link
Member

@tjementum tjementum commented Nov 21, 2023

Summary & Motivation

Set up .NET Aspire AppHost and service defaults. This provides an F5 experience, starting the API, Frontend, and SQL Server by launching the new AppHost .NET project. The existing shared kernel configures service defaults, and the ApiCore .csproj is converted to an IsAspireSharedProject, so only one new project is added (Aspire normally requires two new projects).

The AppHost starts the frontend SPA using Bun, maintaining the frontend tooling.

Starting SQL Server with Aspire's AddContainer() function is disabled due to this error: "A connection was successfully established with the server, but then an error occurred during the pre-login handshake." For now, SQL Server starts with docker compose up sql-server -d using a .NET background process. This method doesn't allow configuration of dependencies, so the SQL Server is given a 3-second delay to start.

Add the Aspire .NET workload into the GitHub workflow. Reorder tasks for consistency across different workflow jobs.

Update README.md to list Aspire as a prerequisite: dotnet workload install aspire. Remove JetBrains ProjectRunConfigurationManager files previously used to start the API and frontend.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label Nov 21, 2023
@tjementum tjementum self-assigned this Nov 21, 2023
@tjementum tjementum linked an issue Nov 21, 2023 that may be closed by this pull request
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@tjementum tjementum merged commit bdee9fe into main Nov 21, 2023
7 checks passed
@tjementum tjementum deleted the aspire branch November 21, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure .NET Aspire
1 participant