Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JetBrains tools to 2023.3 EAP for .NET 8 support #228

Merged
merged 11 commits into from
Nov 22, 2023

Conversation

tjementum
Copy link
Member

@tjementum tjementum commented Nov 22, 2023

Summary & Motivation

Re-enables JetBrains code inspections by upgrading JetBrains.ReSharper.GlobalTools to the 2023.3 Early Access Program (EAP) version with .NET 8 support.

Fix all warnings generated by the new tooling for code optimizations such as RedundantTypeDeclarationBody, ConvertToPrimaryConstructor, PropertyCanBeMadeInitOnly, ParameterHidesPrimaryConstructorParameter, etc.

Update JetBrains formatting rules to place parameters on separate lines for long signatures. Format the entire codebase for consistency, and ensure adherence to conventions.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label Nov 22, 2023
@tjementum tjementum self-assigned this Nov 22, 2023
@tjementum tjementum force-pushed the reenable-jetbrains-code-inspection branch from f03a55e to bf71914 Compare November 22, 2023 17:58
@tjementum tjementum force-pushed the reenable-jetbrains-code-inspection branch from d28f191 to 535614b Compare November 22, 2023 20:07
@tjementum tjementum changed the title Upgrade JetBrains.ReSharper.GlobalTools to 2023.3 EAP for .NET 8 support Upgrade JetBrains tools to 2023.3 EAP for .NET 8 support Nov 22, 2023
@tjementum tjementum force-pushed the reenable-jetbrains-code-inspection branch 2 times, most recently from ac6236f to 535614b Compare November 22, 2023 20:39
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.3% 90.3% Coverage
0.0% 0.0% Duplication

@tjementum tjementum merged commit c4f01b4 into main Nov 22, 2023
12 checks passed
@tjementum tjementum deleted the reenable-jetbrains-code-inspection branch November 22, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant