-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade JetBrains tools to 2023.3 EAP for .NET 8 support #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjementum
force-pushed
the
reenable-jetbrains-code-inspection
branch
from
November 22, 2023 17:58
f03a55e
to
bf71914
Compare
…for long signatures
tjementum
force-pushed
the
reenable-jetbrains-code-inspection
branch
from
November 22, 2023 20:07
d28f191
to
535614b
Compare
tjementum
changed the title
Upgrade JetBrains.ReSharper.GlobalTools to 2023.3 EAP for .NET 8 support
Upgrade JetBrains tools to 2023.3 EAP for .NET 8 support
Nov 22, 2023
tjementum
force-pushed
the
reenable-jetbrains-code-inspection
branch
2 times, most recently
from
November 22, 2023 20:39
ac6236f
to
535614b
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Re-enables JetBrains code inspections by upgrading JetBrains.ReSharper.GlobalTools to the 2023.3 Early Access Program (EAP) version with .NET 8 support.
Fix all warnings generated by the new tooling for code optimizations such as
RedundantTypeDeclarationBody
,ConvertToPrimaryConstructor
,PropertyCanBeMadeInitOnly
,ParameterHidesPrimaryConstructorParameter
, etc.Update JetBrains formatting rules to place parameters on separate lines for long signatures. Format the entire codebase for consistency, and ensure adherence to conventions.
Checklist