Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and speed up application GitHub workflow by combining build and test-with-code-coverage job #229

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

tjementum
Copy link
Member

Summary & Motivation

Optimizes the build pipeline by combining the build and test-with-code-coverage jobs. Both were installing .NET, bun, and restoring .NET packages and tools. Overall, this makes the pipeline complete faster using fewer resources.

Make the jetbrains-code-inspection job run in complete isolation. It must pass before merging pull-requests, but it's not running on main.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label Nov 22, 2023
@tjementum tjementum self-assigned this Nov 22, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tjementum tjementum merged commit 6f5b775 into main Nov 22, 2023
6 checks passed
@tjementum tjementum deleted the simplify-build-pipeline branch November 22, 2023 21:01
tjementum added a commit that referenced this pull request Nov 25, 2023
### Summary & Motivation

In a previous update (refer to [pull request
#229](#229)),
code inspections were inadvertently disabled for pull requests and
enabled for the main branch. This reverts that change, so code
inspections now run on pull requests.


### Checklist

- [x] I have added a Label to the pull-request
- [x] I have added tests, and done manual regression tests
- [x] I have updated the documentation, if necessary
Smurf-Engineer pushed a commit to Smurf-Engineer/Platform that referenced this pull request Apr 8, 2024
### Summary & Motivation

In a previous update (refer to [pull request
#229](platformplatform/PlatformPlatform#229)),
code inspections were inadvertently disabled for pull requests and
enabled for the main branch. This reverts that change, so code
inspections now run on pull requests.


### Checklist

- [x] I have added a Label to the pull-request
- [x] I have added tests, and done manual regression tests
- [x] I have updated the documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant