New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve client app router configuration #231

Merged

tjementum merged 9 commits into main from improve-client-app-router-configuration

Nov 25, 2023

Contributor

raix commented Nov 24, 2023 •

edited

Loading

Summary & Motivation

Improve developer experience - setting up filesystem based routing.
Configuring React Router adding things like error handling, code splitting, dynamic path segments etc. should be as easy as creating a file.

Inspired by NextJS and the ease of use convention based routing.

/app
  layout.tsx - shared layout for child routes
  page.tsx - entry point for this route segment
  error.tsx - page to show when errors occur
  not-found.tsx - page to show if resource not found
  loading.tsx - code split and load this route dynamically
  /[id]
    page.tsx - show details using the param "id"

(NextJS has more functionality to work on server and client - docs)

Checklist

I have added a Label to the pull-request
I have added tests, and done manual regression tests
I have updated the documentation, if necessary

raix self-assigned this

raix added the Enhancement label

tjementum previously approved these changes

View reviewed changes

application/shared-kernel/ApiCore/Middleware/WebAppMiddleware.cs Outdated Show resolved Hide resolved

application/account-management/WebApp/src/shared/router/generate.tsx Outdated Show resolved Hide resolved

application/account-management/WebApp/src/app/tenant/create/success/page.tsx Outdated Show resolved Hide resolved

raix dismissed tjementum’s stale review via

d312392

November 25, 2023 12:20

raix force-pushed the improve-client-app-router-configuration branch from d312392 to e14db3d Compare

November 25, 2023 12:21

raix added 9 commits

November 25, 2023 13:43


          Remove unnecessary curly brackets

ffe8d0e


          Clean rspack build folder "dist"

0bdfd09


          Move general lib and runtime to shared folder

93b1ea6


          WebApp middleware wait for development build to be ready

243f2d5


          Refactor into app folder routing

b351d1d


          Initial app folder routing

c34ff2f


          WebApp middleware should not check for index.html in development

902da06


          Remove console log in success page

effa9d9


          Use consistent Error messages

62424e4

Errors should contain a sentence describing the issue ending with a "."
Error("Could not load file.")

tjementum changed the title ~~Improve-client-app-router-configuration~~ Improve client app router configuration

raix force-pushed the improve-client-app-router-configuration branch from e14db3d to 62424e4 Compare

November 25, 2023 12:43

sonarqubecloud bot commented Nov 25, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

raix marked this pull request as ready for review

November 25, 2023 12:47

tjementum approved these changes

View reviewed changes

tjementum merged commit c61c338 into main

6 checks passed

tjementum deleted the improve-client-app-router-configuration branch

November 25, 2023 12:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels