Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of links to tutorials #548

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rudilp28
Copy link
Contributor

@rudilp28 rudilp28 commented Feb 3, 2022

Added links to platform tutorials, so tasks have an explanatory tutorial.
Added icon fron AntDesign.

Copy link
Contributor

@LuanEdCosta LuanEdCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prototype

image

Implemented

image


Ant Design doesn't have the icon used on the prototype, so you don't need to change the icon, but you should align the tutorial link icon at the end of the draggable item.

@@ -9,6 +9,15 @@

padding-left: 24px !important;

.icon-url {
position: absolute;
left: 220px;
Copy link
Contributor

@LuanEdCosta LuanEdCosta Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid fixing the position like this, because it is a bad practice. Try to use the margin-left CSS property to align the icon on the right.

LuanEdCosta
LuanEdCosta previously approved these changes Feb 7, 2022
@LuanEdCosta LuanEdCosta marked this pull request as draft February 8, 2022 14:44
@LuanEdCosta LuanEdCosta changed the base branch from master to develop February 23, 2022 16:43
@LuanEdCosta LuanEdCosta dismissed their stale review February 23, 2022 16:43

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants