Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty message posted #35

Open
lukaas33 opened this issue Dec 5, 2024 · 3 comments
Open

Empty message posted #35

lukaas33 opened this issue Dec 5, 2024 · 3 comments

Comments

@lukaas33
Copy link

lukaas33 commented Dec 5, 2024

Hi, I am using this tool, but it is only posting empty comments.
Is there any way to check why? This is happenign in a private repo.

This is the config, note that it was also posting empty comments before adding one_comment: true

name: Replication

on: pull_request

jobs:
  duplicate-code-check:
    name: Check for duplicate code
    runs-on: ubuntu-20.04
    steps:     
      - name: Check for duplicate code
        uses: platisd/duplicate-code-detection-tool@master
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          one_comment: true
@platisd
Copy link
Owner

platisd commented Dec 5, 2024

Have you tried running the python tool first manually?

@lukaas33
Copy link
Author

lukaas33 commented Dec 7, 2024

Hi,

I have ran it locally and it returns the following:

Code duplication probability for ...\fragshader.c
----------------------------------------------------------------------------------------------------------
                                            File                                             Similarity (%)
----------------------------------------------------------------------------------------------------------
...\vertshader.c     0.00



Code duplication probability for C:\Users\Lucas\Code\profoundvision-website\public\assets\components\neuronnoise\vertshader.c
----------------------------------------------------------------------------------------------------------
                                            File                                             Similarity (%)
----------------------------------------------------------------------------------------------------------
....\fragshader.c     0.00

So is this expected behavior that the report is empty when the probability is so low? Would it not be possible to post no comment instead of an empty one in this case?

@platisd
Copy link
Owner

platisd commented Dec 7, 2024

When you run the Action, the ignore_below value is set to 10.
To show everything, try setting it to 0. See the optional configuration example which does ignore_below: 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants