Feature: Support user input label #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasberik
commented
Jul 16, 2024
| @@ -43,7 +43,8 @@ public struct AccessibilitySnapshot: TestTool { | |||
| let accessibilityView = AccessibilitySnapshotView( | |||
| containedView: view.superview ?? view, | |||
| viewRenderingMode: .renderLayerInContext, | |||
| activationPointDisplayMode: .always | |||
| activationPointDisplayMode: .always, | |||
| showUserInputLabels: true | |||
There was a problem hiding this comment.
Default opt in, this is mandatory to provide to adopt 0.7.0
rasberik
commented
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccessibilitySnapshot library introduced breaking change in this cashapp/AccessibilitySnapshot#150.
It is a feature to show https://developer.apple.com/documentation/objectivec/nsobject/3197989-accessibilityuserinputlabels for UIKit elements, and may cause diff changes for such UIKit elements
Due to its nature, I opted in by default, as it is make sense to have it in default behavior.
So in case of releasing new version, need to warn about potential differences for such views.
Also bumping in other dependencies and nit updating some docs.
Evidence
Both are taken after changes to
accessibilityUserInputLabels.