-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jvm and ios-async-node-ability-to-remove-resolved-async-node #488
Merged
sakuntala-motukuri
merged 32 commits into
main
from
jvm-async-node-ability-to-remove-resolved-async-node
Sep 3, 2024
Merged
jvm and ios-async-node-ability-to-remove-resolved-async-node #488
sakuntala-motukuri
merged 32 commits into
main
from
jvm-async-node-ability-to-remove-resolved-async-node
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 91.97% 91.95% -0.03%
==========================================
Files 340 340
Lines 26960 27195 +235
Branches 1945 1945
==========================================
+ Hits 24796 25006 +210
- Misses 2150 2175 +25
Partials 14 14 ☔ View full report in Codecov by Sentry. |
sakuntala-motukuri
changed the title
Initial code commit
jvm and ios-async-node-ability-to-remove-resolved-async-node
Aug 13, 2024
sakuntala-motukuri
requested review from
nancywu1
and removed request for
nancywu1
August 13, 2024 23:44
sugarmanz
reviewed
Aug 14, 2024
.../async-node/jvm/src/test/kotlin/com/intuit/playerui/plugins/asyncnode/AsyncNodePluginTest.kt
Outdated
Show resolved
Hide resolved
brocollie08
reviewed
Aug 14, 2024
.../async-node/jvm/src/test/kotlin/com/intuit/playerui/plugins/asyncnode/AsyncNodePluginTest.kt
Outdated
Show resolved
Hide resolved
brocollie08
reviewed
Aug 16, 2024
.../async-node/jvm/src/test/kotlin/com/intuit/playerui/plugins/asyncnode/AsyncNodePluginTest.kt
Outdated
Show resolved
Hide resolved
nancywu1
reviewed
Aug 19, 2024
brocollie08
reviewed
Aug 20, 2024
brocollie08
reviewed
Aug 20, 2024
.../async-node/jvm/src/test/kotlin/com/intuit/playerui/plugins/asyncnode/AsyncNodePluginTest.kt
Outdated
Show resolved
Hide resolved
.../async-node/jvm/src/test/kotlin/com/intuit/playerui/plugins/asyncnode/AsyncNodePluginTest.kt
Show resolved
Hide resolved
.../async-node/jvm/src/test/kotlin/com/intuit/playerui/plugins/asyncnode/AsyncNodePluginTest.kt
Outdated
Show resolved
Hide resolved
.../async-node/jvm/src/test/kotlin/com/intuit/playerui/plugins/asyncnode/AsyncNodePluginTest.kt
Outdated
Show resolved
Hide resolved
nancywu1
reviewed
Aug 23, 2024
nancywu1
reviewed
Aug 23, 2024
nancywu1
reviewed
Aug 23, 2024
sugarmanz
previously approved these changes
Aug 26, 2024
nancywu1
reviewed
Aug 26, 2024
hborawski
reviewed
Aug 26, 2024
hborawski
reviewed
Aug 26, 2024
sakuntala-motukuri
requested review from
hborawski and
sugarmanz
and removed request for
brocollie08
September 3, 2024 18:37
hborawski
approved these changes
Sep 3, 2024
sugarmanz
approved these changes
Sep 3, 2024
sakuntala-motukuri
deleted the
jvm-async-node-ability-to-remove-resolved-async-node
branch
September 3, 2024 19:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Does your PR have any documentation updates?
Version
Published prerelease version:
0.9.0-next.7
Changelog
Release Notes
Update Rules Versions (#496)
Update JS Rules to latest Aspect major
Android/JVM - expose constantController (#489)
Expose the core Player constantsController to Android/JVM consumers
AndroidPlayer provides top-level api and plugins access including
constantsController
with AssetContextSample usage:
assetContext.player.constantsController.getConstants(key, namespace)
Storybook Addon Fixes (#449)
[Hermes] Android integration (#410)
Initial integration with the Hermes JavaScript runtime. This shows a tremendous size improvement over the existing J2V8 integration of ~70% (7.6 MB -> 2.3 MB, architecture dependent).
Opt-in
For now, the default runtime integration provided by the Android Player will still be
com.intuit.playerui:j2v8-android
, but Hermes can be opted in manually by excluding the J2V8 transitive dependency and including the Hermes artifact:Most of the setup for this integration is done simply by including the right dependency (and excluding the wrong one), however, the
hermes-android
integration also relies on the SoLoader for loading the native libraries. All that's needed is to initialize theSoLoader
(should be on your classpath with thehermes-android
dependency) with an AndroidContext
somewhere before you use theAndroidPlayer
, potentially in your activitiesonCreate
:🚀 Enhancement
🐛 Bug Fix
config=ci
#482 (@sugarmanz)🏠 Internal
Authors: 7