Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS ExternalActionViewModifierPlugin: expose controllers, transition func, and apply func #539

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nancywu1
Copy link
Contributor

@nancywu1 nancywu1 commented Nov 5, 2024

Expose controllers, transition func, and apply func for ExternalWidgetPlugin

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 0.9.2--canary.539.18149

Try this version out locally by upgrading relevant packages to 0.9.2--canary.539.18149

@nancywu1
Copy link
Contributor Author

nancywu1 commented Nov 5, 2024

/canary

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (0fb5a67) to head (e4fb8f6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...tui/Sources/ExternalActionViewModifierPlugin.swift 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files         341      341              
  Lines       27303    27309       +6     
  Branches     1944     1944              
==========================================
+ Hits        25087    25092       +5     
- Misses       2202     2203       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant