From 1bc9b3a7045a9b7869a69e2467c45d30f9d3372d Mon Sep 17 00:00:00 2001 From: Chloe Han Date: Fri, 16 Aug 2024 13:41:30 -0400 Subject: [PATCH 1/5] fix:no matching toolchains:ninja_toolchain --- MODULE.bazel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MODULE.bazel b/MODULE.bazel index 33863e917..e751b1897 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -21,7 +21,7 @@ bazel_dep(name = "rules_pkg", version = "1.0.1") bazel_dep(name = "aspect_rules_ts", version = "2.4.2") # C++ -bazel_dep(name = "rules_foreign_cc", version = "0.10.1") +bazel_dep(name = "rules_foreign_cc", version = "0.11.1") bazel_dep(name = "googletest", version = "1.14.0") ####### Node.js version ######### From 5a3529cf91ef815ab4e407eb3fac5a850ef2fe0b Mon Sep 17 00:00:00 2001 From: Ketan Reddy Date: Mon, 19 Aug 2024 11:24:26 -0700 Subject: [PATCH 2/5] Add recommended build buddy flags --- .bazelrc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.bazelrc b/.bazelrc index 7d0258c8f..837f2f5ac 100644 --- a/.bazelrc +++ b/.bazelrc @@ -50,6 +50,9 @@ common:ci --build_metadata=ROLE=CI --workspace_status_command=./scripts/workspac common:ci --local_cpu_resources=8 common:ci --local_ram_resources=15000 common:ci --config="release" +common:ci --experimental_remote_build_event_upload=minimal +common:ci --nolegacy_important_outputs + # Circle macos.m1.large.gen1 8 cores 12gb ram common:ci-mac --config=ci --local_cpu_resources=8 --local_ram_resources=11000 From a8edb14e78760d3dd7b5dc0284daf74ff42c3c68 Mon Sep 17 00:00:00 2001 From: sentony93 Date: Mon, 19 Aug 2024 15:23:21 -0400 Subject: [PATCH 3/5] separate run for hermes --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index dd7475d71..7629a2dbe 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -235,9 +235,9 @@ jobs: - attach_workspace: at: ~/player - - run: | - bazel test --config=ci -- $(bazel query 'kind(".*_test", //...) except filter("ios|swiftui", //...)') -//android/demo:android_instrumentation_test - bazel test --config=ci --//android/player:runtime=hermes -- $(bazel query 'kind(".*_test", //...) except filter("ios|swiftui", //...)') -//android/demo:android_instrumentation_test + - run: bazel test --config=ci -- $(bazel query 'kind(".*_test", //...) except filter("ios|swiftui", //...)') -//android/demo:android_instrumentation_test + + - run: bazel test --config=ci --//android/player:runtime=hermes -- $(bazel query 'kind(".*_test", //...) except filter("ios|swiftui", //...)') -//android/demo:android_instrumentation_test - run: when: always From 5096c0b83d311bf9d9c57e5ee6fa4c4fdad34de2 Mon Sep 17 00:00:00 2001 From: sentony93 Date: Mon, 19 Aug 2024 16:38:49 -0400 Subject: [PATCH 4/5] limit local_ram_resources --- .bazelrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bazelrc b/.bazelrc index 837f2f5ac..fabdd681b 100644 --- a/.bazelrc +++ b/.bazelrc @@ -48,7 +48,7 @@ common:ci --build_metadata=ROLE=CI --workspace_status_command=./scripts/workspac # Circle xlarge has 8 CPU cores/16GB mem common:ci --local_cpu_resources=8 -common:ci --local_ram_resources=15000 +common:ci --local_ram_resources=14000 common:ci --config="release" common:ci --experimental_remote_build_event_upload=minimal common:ci --nolegacy_important_outputs From 2b55b224bdb47315093d21b60b49a90a983502c8 Mon Sep 17 00:00:00 2001 From: sentony93 Date: Mon, 19 Aug 2024 19:39:22 -0400 Subject: [PATCH 5/5] separate hermes build --- .bazelrc | 2 +- .circleci/config.yml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.bazelrc b/.bazelrc index fabdd681b..837f2f5ac 100644 --- a/.bazelrc +++ b/.bazelrc @@ -48,7 +48,7 @@ common:ci --build_metadata=ROLE=CI --workspace_status_command=./scripts/workspac # Circle xlarge has 8 CPU cores/16GB mem common:ci --local_cpu_resources=8 -common:ci --local_ram_resources=14000 +common:ci --local_ram_resources=15000 common:ci --config="release" common:ci --experimental_remote_build_event_upload=minimal common:ci --nolegacy_important_outputs diff --git a/.circleci/config.yml b/.circleci/config.yml index 7629a2dbe..3be531a14 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -235,6 +235,8 @@ jobs: - attach_workspace: at: ~/player + - run: bazel test --config=ci -- //third_party/hermes/hello:test + - run: bazel test --config=ci -- $(bazel query 'kind(".*_test", //...) except filter("ios|swiftui", //...)') -//android/demo:android_instrumentation_test - run: bazel test --config=ci --//android/player:runtime=hermes -- $(bazel query 'kind(".*_test", //...) except filter("ios|swiftui", //...)') -//android/demo:android_instrumentation_test