Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for account creation import #57

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

gjong
Copy link
Contributor

@gjong gjong commented Sep 17, 2024

Breaking change

Proposed change

Change the import job of transactions to push the newly created account into the account mappings. This will allow all further transactions with the same account name to automatically pick up the newly created account.

Also slightly update the logging to make it more concise on running systems and easier to tail.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the application)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

Copy link

sonarcloud bot commented Sep 17, 2024

@gjong gjong merged commit 57941e7 into master Sep 17, 2024
6 checks passed
@gjong gjong deleted the update-import-create-account-flow branch September 17, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant