chore: upgrade to eslint 9 (#876)

apps/server/package.json

@@ -6,8 +6,8 @@
   "scripts": {
     "dev": "nodemon",
     "start": "nodemon",
-    "lint": "eslint . --ext .ts",
-    "lint:fix": "eslint . --ext .ts --fix",
+    "lint": "echo \"No linting configured for server app\"",
+    "lint:fix": "echo \"No linting configured for server app\"",
     "build": "tsup --minify"
   },
   "dependencies": {

apps/web/__tests__/support/commands.ts

@@ -34,14 +34,14 @@ Cypress.Commands.add('waitUntilElementInDOM', (actionToWaitOn: () => Cypress.Cha
   cy.waitUntil(() =>
     actionToWaitOn()
       .should('have.length.gte', 0)
-      .then((element) => !!element.length),
+      .then(element => !!element.length),
   ),
 );
 
 Cypress.Commands.add('clearServiceWorkers', () => {
   // Fix for stuck visit even though page is loaded in cypress
   if (window.navigator && navigator.serviceWorker) {
-    const registrationPromise = window.navigator.serviceWorker.getRegistrations().then((registrations) =>
+    const registrationPromise = window.navigator.serviceWorker.getRegistrations().then(registrations =>
       registrations.forEach((registration) => {
         registration.unregister();
       }),

apps/web/__tests__/support/failOnError.ts

@@ -4,8 +4,8 @@ const ignoreErrors = [
   'turnstile',
 ];
 
-Cypress.on("window:before:load", win => {
-  cy.stub(win.console, "error").callsFake(msg => {
+Cypress.on("window:before:load", (win) => {
+  cy.stub(win.console, "error").callsFake((msg) => {
     throw new Error(msg)
   })
 });

apps/web/__tests__/support/pageObjects/EditorObject.ts

@@ -114,7 +114,7 @@ export class EditorObject extends PageObject {
   replaceEditorContent(content: string) {
     this.editorTextarea
       .should('be.visible')
-      .then($el => {
+      .then(($el) => {
         if ($el.prop('isContentEditable')) {
           cy.wrap($el).invoke('text', '');
         } else {
@@ -156,7 +156,7 @@ export class EditorObject extends PageObject {
   }
 
   deleteBlock() {
-    this.blockWrapper.then(initialBlocks => {
+    this.blockWrapper.then((initialBlocks) => {
       const initialLength = initialBlocks.length;
       this.blockWrapper.first().should('exist');
       this.deleteBlockButton.eq(1).click();
@@ -182,7 +182,7 @@ export class EditorObject extends PageObject {
   }
 
   addBlockTop() {
-    this.blockWrapper.then(initialBlocks => {
+    this.blockWrapper.then((initialBlocks) => {
       const initialLength = initialBlocks.length;
       this.topBlockButton.invoke('removeClass', 'opacity-0');
       this.topBlockButton.first().should('exist').click();
@@ -192,7 +192,7 @@ export class EditorObject extends PageObject {
   }
 
   addBlockBottom() {
-    this.blockWrapper.then(initialBlocks => {
+    this.blockWrapper.then((initialBlocks) => {
       const initialLength = initialBlocks.length;
       this.bottomBlockButton.invoke('removeClass', 'opacity-0');
       this.bottomBlockButton.first().should('exist').click();

apps/web/__tests__/test/feature/auth-guard.cy.ts

@@ -60,7 +60,7 @@ describe('Auth Guard', () => {
 
         cy.wait('@doLogin');
 
-        guardedRoutes.forEach(route => {
+        guardedRoutes.forEach((route) => {
             cy.visitAndHydrate(route);
             cy.url().should('include', route);
         });

apps/web/__tests__/test/unit/i18n.spec.ts

@@ -12,15 +12,15 @@ describe('i18n', () => {
     it('has values for all English keys', () => {
         const valuesEn: Array<string | object> = Object.values(en);
 
-        valuesEn.forEach(value => {
+        valuesEn.forEach((value) => {
             hasText(value);
         })
     });
 
     it('has values for all German keys', () => {
         const valuesDe: Array<string | object> = Object.values(de);
 
-        valuesDe.forEach(value => {
+        valuesDe.forEach((value) => {
             hasText(value);
         })
     });
@@ -76,7 +76,7 @@ const hasText = (value: string | object) => {
     if (isObject(value)) {
         expect(JSON.stringify(value)).not.toEqual('{}');
 
-        Object.values(value).forEach(childValue => {
+        Object.values(value).forEach((childValue) => {
             hasText(childValue);
         })
     }

apps/web/build/configurator/AppConfigurator.ts

@@ -1,10 +1,10 @@
 import dotenv from 'dotenv';
 import path, { dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
-import { BaseColors, ConfigurationCategory, ConfigurationEntry, ConfigurationResponse, Languages } from './types';
+import type { BaseColors, ConfigurationCategory, ConfigurationEntry, ConfigurationResponse, Languages } from './types';
 import { getPaletteFromColor } from '../../utils/tailwindHelper';
-import { Writer } from '../writers/types';
-import { Logger } from '../logs/types';
+import type { Writer } from '../writers/types';
+import type { Logger } from '../logs/types';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);

apps/web/build/configurator/AssetDownloader.ts

@@ -1,8 +1,8 @@
 import path, { dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { FileTypeValidator } from '../validators/FileTypeValidator';
-import { Writer } from '../writers/types';
-import { Logger } from '../logs/types';
+import type { Writer } from '../writers/types';
+import type { Logger } from '../logs/types';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);

apps/web/build/configurator/SystemConfiguration.ts

@@ -1,6 +1,7 @@
-import axios, { AxiosRequestConfig } from 'axios';
+import type { AxiosRequestConfig } from 'axios';
+import axios from 'axios';
 import https from 'node:https';
-import { ConfigurationResponse, BaseColors, Languages } from './types';
+import type { ConfigurationResponse, BaseColors, Languages } from './types';
 
 export class SystemConfiguration {
   private axiosRequestConfig: AxiosRequestConfig = {

apps/web/build/configurator/__tests__/AppConfigurator.spec.ts

@@ -1,8 +1,8 @@
 import { describe, it, expect, vi } from 'vitest';
 import { AppConfigurator } from '../AppConfigurator';
-import { BaseColors, ConfigurationResponse } from '../types';
-import { Writer } from '../../writers/types';
-import { Logger } from '../../logs/types';
+import type { BaseColors, ConfigurationResponse } from '../types';
+import type { Writer } from '../../writers/types';
+import type { Logger } from '../../logs/types';
 
 describe('AppConfigurator', () => {
     let writerMock: Writer;

apps/web/build/configurator/__tests__/AssetDownloader.spec.ts

@@ -1,8 +1,8 @@
 import { describe, it, expect, vi } from 'vitest';
 import { AssetDownloader } from '../AssetDownloader';
 import { FileTypeValidator } from '../../validators/FileTypeValidator';
-import { Writer } from '../../writers/types';
-import { Logger } from '../../logs/types';
+import type { Writer } from '../../writers/types';
+import type { Logger } from '../../logs/types';
 import path from 'path';
 
 describe('AssetDownloader', () => {

apps/web/build/index.ts

@@ -36,7 +36,6 @@ const main = async () => {
   }
 };
 
-// eslint-disable-next-line etc/no-implicit-any-catch
 await main().catch((error: Error) => {
   BuildLoggerInstance.error('An error occurred:', error);
 });

apps/web/build/logs/Logger.ts

@@ -1,7 +1,8 @@
 import path, { dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
-import { createWriteStream, WriteStream } from 'node:fs';
-import { Logger } from './types';
+import type { WriteStream } from 'node:fs';
+import { createWriteStream } from 'node:fs';
+import type { Logger } from './types';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);

apps/web/build/writers/CdnToFileWriter.ts

@@ -1,7 +1,7 @@
 import axios from 'axios';
 import { existsSync, writeFileSync } from 'node:fs';
-import { Writer } from './types';
-import { Logger } from '../logs/types';
+import type { Writer } from './types';
+import type { Logger } from '../logs/types';
 
 export class CdnToFileWriter implements Writer {
   private logger: Logger;

apps/web/build/writers/DataToFileWriter.ts

@@ -1,6 +1,6 @@
 import { writeFileSync, existsSync } from 'node:fs';
-import { Writer } from './types';
-import { Logger } from '../logs/types';
+import type { Writer } from './types';
+import type { Logger } from '../logs/types';
 
 export class DataToFileWriter implements Writer {
   private logger: Logger;

apps/web/components/AccountForms/AccountFormsName.vue

@@ -1,13 +1,13 @@
 <template>
-  <form @submit.prevent="$emit('on-save')" data-testid="account-forms-name">
+  <form data-testid="account-forms-name" @submit.prevent="$emit('on-save')">
     <div class="md:flex justify-between gap-4">
       <label class="block flex-1">
         <UiFormLabel>{{ $t('account.accountSettings.personalData.firstName') }} {{ $t('form.required') }}</UiFormLabel>
-        <SfInput name="firstname" type="text" v-model="userData.firstName" required />
+        <SfInput v-model="userData.firstName" name="firstname" type="text" required />
       </label>
       <label class="block flex-1 mt-4 md:mt-0">
         <UiFormLabel>{{ $t('account.accountSettings.personalData.lastName') }} {{ $t('form.required') }}</UiFormLabel>
-        <SfInput name="lastname" type="text" v-model="userData.lastName" required />
+        <SfInput v-model="userData.lastName" name="lastname" type="text" required />
       </label>
     </div>
     <div class="mt-6 flex flex-col-reverse md:flex-row md:justify-end gap-4">

apps/web/components/AccountForms/AccountFormsPassword.vue

@@ -1,22 +1,22 @@
 <template>
-  <form @submit.prevent="submitChangePassword" data-testid="account-forms-password">
+  <form data-testid="account-forms-password" @submit.prevent="submitChangePassword">
     <label class="block">
       <UiFormLabel
         >{{ t('account.accountSettings.personalData.currentPassword') }} {{ $t('form.required') }}</UiFormLabel
       >
       <UiFormPasswordInput
+        v-model="userPasswords.oldPassword"
         name="password"
         autocomplete="current-password"
-        v-model="userPasswords.oldPassword"
         required
       />
     </label>
     <label class="block my-4">
       <UiFormLabel>{{ t('account.accountSettings.personalData.newPassword') }} {{ $t('form.required') }}</UiFormLabel>
       <UiFormPasswordInput
+        v-model="userPasswords.firstNewPassword"
         name="password"
         autocomplete="new-password"
-        v-model="userPasswords.firstNewPassword"
         required
         minlength="8"
         pattern="^(?=.*[A-Za-z])(?=.*\d)\S{8,}$"
@@ -28,9 +28,9 @@
         >{{ t('account.accountSettings.personalData.newPasswordAgain') }} {{ $t('form.required') }}</UiFormLabel
       >
       <UiFormPasswordInput
+        v-model="userPasswords.secondNewPassword"
         name="password"
         autocomplete="new-password"
-        v-model="userPasswords.secondNewPassword"
         required
         minlength="8"
         pattern="^(?=.*[A-Za-z])(?=.*\d)\S{8,}$"

apps/web/components/Address/Address.vue

@@ -42,7 +42,7 @@
 
 <script lang="ts" setup>
 import { SfIconCheckCircle } from '@storefront-ui/vue';
-import { type AddressProps } from './types';
+import type { AddressProps } from './types';
 import { userAddressGetters } from '@plentymarkets/shop-api';
 
 const { address, isDefault, isSelected, showDivider } = defineProps<AddressProps>();

apps/web/components/AddressContainer/AddressContainer.vue

@@ -14,11 +14,11 @@
           @edit="edit"
         />
         <UiButton
-          :data-testid="'save-address-' + type"
           v-else
-          @click="validateAndSubmitForm"
+          :data-testid="'save-address-' + type"
           :disabled="formIsLoading"
           variant="secondary"
+          @click="validateAndSubmitForm"
         >
           {{ t('saveAddress') }}
         </UiButton>
@@ -29,10 +29,10 @@
           :label="!editing && !showNewForm && !disabled ? t('editAddress') : ''"
         >
           <UiButton
-            @click="edit(checkoutAddress)"
             :disabled="formIsLoading || disabled"
             variant="secondary"
             :data-testid="'edit-address-' + type"
+            @click="edit(checkoutAddress)"
           >
             <template v-if="!editing && !showNewForm">{{ t('contactInfo.edit') }}</template>
             <SfIconClose v-else />
@@ -67,7 +67,7 @@
 
 <script setup lang="ts">
 import { SfIconClose, SfTooltip } from '@storefront-ui/vue';
-import { type AddressContainerProps } from './types';
+import type { AddressContainerProps } from './types';
 import { type Address, AddressType } from '@plentymarkets/shop-api';
 
 const { disabled = false, type } = defineProps<AddressContainerProps>();

apps/web/components/AddressContainer/types.ts

@@ -1,4 +1,4 @@
-import { AddressType } from '@plentymarkets/shop-api';
+import type { AddressType } from '@plentymarkets/shop-api';
 
 export type AddressContainerProps = {
   disabled?: boolean;

apps/web/components/AddressDisplay/AddressDisplay.vue

@@ -20,7 +20,7 @@
 
 <script lang="ts" setup>
 import { userAddressGetters } from '@plentymarkets/shop-api';
-import { type AddressProps } from './types';
+import type { AddressProps } from './types';
 
 const { address } = defineProps<AddressProps>();
 

apps/web/components/AddressDisplay/types.ts

@@ -1,4 +1,4 @@
-import { type Address } from '@plentymarkets/shop-api';
+import type { Address } from '@plentymarkets/shop-api';
 
 export type AddressProps = {
   address: Address;