Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build on windows #760

Merged
merged 18 commits into from
Nov 1, 2024
Merged

fix: build on windows #760

merged 18 commits into from
Nov 1, 2024

Conversation

ksted
Copy link
Contributor

@ksted ksted commented Oct 25, 2024

Why:

Windows OS doesn't accept : in file names. This currently fails the build because the build script logger generates log files with an ISO string pattern.

Describe your changes

  • Adds workflow for checking the build on different operating systems.
  • Changes the log file names to work on Windows.

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@github-actions github-actions bot added the fix Patch a bug label Oct 25, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 25, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 28, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 28, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 28, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 28, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 31, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 31, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Nov 1, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Nov 1, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Nov 1, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Nov 1, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Nov 1, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Nov 1, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Nov 1, 2024
@ksted ksted marked this pull request as ready for review November 1, 2024 09:32
@ksted ksted requested a review from a team as a code owner November 1, 2024 09:32
@ksted ksted enabled auto-merge (squash) November 1, 2024 09:34
@ksted ksted merged commit 4e28470 into main Nov 1, 2024
8 checks passed
@ksted ksted deleted the fix/build-windows branch November 1, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Patch a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants