Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to eslint 9 #876

Merged
merged 19 commits into from
Jan 10, 2025
Merged

chore: upgrade to eslint 9 #876

merged 19 commits into from
Jan 10, 2025

Conversation

ksted
Copy link
Contributor

@ksted ksted commented Dec 9, 2024

Why:

Regular dependency update.

Describe your changes

  • Upgrades ESLint to v9.
  • Migrates configuration to use flat config.
  • Updates rules.
  • Updates files to comply with the new rules.

Additional references

Vsf has a TypeScript configuration as well, but it forces us to use a different Nuxt module configuration that, in combination, crashes the TS parser. The Nuxt module comes with its own set of recommended rules for TypeScript, so I think we're better off using that as base and customising it as we see fit.

Open question: Should we continue to use unicorn rules?

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@ksted ksted marked this pull request as ready for review January 10, 2025 12:42
@ksted ksted requested a review from a team as a code owner January 10, 2025 12:42
@ksted ksted merged commit 1ae3d4a into main Jan 10, 2025
10 of 11 checks passed
@ksted ksted deleted the chore/upgrade-eslint branch January 10, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants