Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: homepage recommended products #932

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Conversation

ksted
Copy link
Contributor

@ksted ksted commented Jan 2, 2025

Why:

  • When connecting to a Plenty system, the recommended products aren't displayed on the homepage on initial load.
  • AB#141475

Describe your changes

  • Calls recommended products after fetching the homepage template.
  • Assigns a unique key to the recommended products, in case a page uses multiple instances of recommended products.
  • Removes the RecommendedProducts component because it's a redundant layer.

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@github-actions github-actions bot added the fix Patch a bug label Jan 2, 2025
@ksted ksted marked this pull request as ready for review January 2, 2025 15:27
@ksted ksted requested a review from a team as a code owner January 2, 2025 15:27
@ksted ksted merged commit c58c400 into main Jan 8, 2025
11 checks passed
@ksted ksted deleted the fix/homepage-recommended-products branch January 8, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Patch a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants