added structured data markup and aria labels to site navigation #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-M-S
added
the
translation required
Tim-M-S
reviewed
Aug 9, 2024
| class="navbar-toggler d-lg-none p-3" | ||
| type="button" | ||
| id="mobile-navigation-toggler" | ||
| for="mobile-navigation-wrapper" |
There was a problem hiding this comment.
Suggested change
| for="mobile-navigation-wrapper" |
I don't think the for attribute is allowed on anything besides <label> and <output>
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/for
Tim-M-S
reviewed
Aug 9, 2024
| type="button" | ||
| id="mobile-navigation-toggler" | ||
| for="mobile-navigation-wrapper" | ||
| aria-controls="menu" |
There was a problem hiding this comment.
Wouldn't this only work if there was an interactive element with id="menu" ?
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls
Tim-M-S
reviewed
Aug 9, 2024
| @@ -559,6 +559,9 @@ myAccountSave = "Save" | |||
| myAccountSettings = "Account settings" | |||
| myAccountShippingAddresses = "Delivery addresses" | |||
| ; myAccount - My account | |||
| ; navigation | |||
| menuLabel = "Menu" | |||
There was a problem hiding this comment.
Suggested change
| menuLabel = "Menu" | |
| menuLabel = "Open mobile navigation menu" |
I think this is a bit more descriptive
Tim-M-S
reviewed
Aug 9, 2024
| @@ -556,6 +556,9 @@ myAccountSave = "Speichern" | |||
| myAccountSettings = "Kontoeinstellungen" | |||
| myAccountShippingAddresses = "Lieferadressen" | |||
| ; myAccount - My account | |||
| ; navigation | |||
| menuLabel = "Menü" | |||
There was a problem hiding this comment.
Open mobile navigation menu
Suggested change
| menuLabel = "Menü" | |
| menuLabel = "Mobiles Navigationsmenü öffnen" |
I think this is a bit more descriptive
Tim-M-S
reviewed
Aug 9, 2024
| <button v-open-mobile-navigation class="navbar-toggler d-lg-none p-3" type="button"> | ||
| <button v-open-mobile-navigation | ||
| class="navbar-toggler d-lg-none p-3" | ||
| type="button" |
There was a problem hiding this comment.
Suggested change
| type="button" | |
| type="menu" |
Wouldn't type="menu" be more accurate here?
https://developer.mozilla.org/en-US/docs/Web/API/HTMLButtonElement#htmlbuttonelement.type
fmutschler
removed
the
translation required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes meet the following requirements
@plentymarkets/plentyshop
please test. Some changes are not being tested by the author