🐛Fix potential problem cleaning before restoring .NET projects

pleonex · Nov 18, 2023 · 590326d · 590326d
1 parent 6866508
commit 590326d
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/src/Cake.Frosting.PleOps.Recipe/Dotnet/RestoreDependenciesTask.cs b/src/Cake.Frosting.PleOps.Recipe/Dotnet/RestoreDependenciesTask.cs
@@ -35,17 +35,6 @@ public class RestoreDependenciesTask : FrostingTask<PleOpsBuildContext>
     /// <inheritdoc />
     public override void Run(PleOpsBuildContext context)
     {
-        if (!context.IsIncrementalBuild) {
-            context.Log.Information("Cleaning .NET projects for selected configuration and platform");
-            var cleanSettings = new DotNetCleanSettings {
-                Verbosity = context.DotNetContext.ToolingVerbosity,
-                Configuration = context.DotNetContext.Configuration,
-                MSBuildSettings = new DotNetMSBuildSettings()
-                    .WithProperty("Platform", context.DotNetContext.Platform),
-            };
-            context.DotNetClean(context.DotNetContext.SolutionPath, cleanSettings);
-        }
-
         MSBuildTreatAllWarningsAs warningMode = context.WarningsAsErrors
             ? MSBuildTreatAllWarningsAs.Error
             : MSBuildTreatAllWarningsAs.Default;
@@ -64,5 +53,19 @@ public override void Run(PleOpsBuildContext context)
         }
 
         context.DotNetRestore(context.DotNetContext.SolutionPath, dotnetSettings);
+
+        // Clean must happen after restore, otherwise it may fail
+        // https://github.com/dotnet/sdk/issues/4018
+        // https://github.com/dotnet/sdk/issues/30199
+        if (!context.IsIncrementalBuild) {
+            context.Log.Information("Cleaning .NET projects for selected configuration and platform");
+            var cleanSettings = new DotNetCleanSettings {
+                Verbosity = context.DotNetContext.ToolingVerbosity,
+                Configuration = context.DotNetContext.Configuration,
+                MSBuildSettings = new DotNetMSBuildSettings()
+                    .WithProperty("Platform", context.DotNetContext.Platform),
+            };
+            context.DotNetClean(context.DotNetContext.SolutionPath, cleanSettings);
+        }
     }
 }