-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve tagging support if hyperref is not used #1366
Comments
Sounds like a plan. I also found biblatex/tex/latex/biblatex/biblatex.sty Lines 12167 to 12205 in 58f64eb
so that |
Ah. Another thing: For the |
Sorry I didn't really check your code (or I did but that was sometimes last year when I wrote the tagging support ;-)). I only remember that I couldn't find a clean hook if hyperref is not loaded.
The names of the commands do not really fit to biblatex, but nevertheless I think one can view them as "official" citations interfaces. and I do not think there is a problem if biblatex does like natbib
and uses them where suited. hyperref redefines that currently like this,
It is quite possible that at some time the tagging code is added directly and not through hooks as it is done now. So if you see any need to change these definitions, please tell us and do not redefine them silently! |
Yes, I assume so. At least with pdflatex the tagging code inserts whatsits. |
Ah, nice. That should unify the interface a little. Thanks for the answer. I will see if I can rustle something up. |
we now "rely" on hyperref commands and \providecommand them if they don't exist.
It would be great if you could have a look at moewew@c8198ff in https://github.com/moewew/biblatex/tree/nohypertag and give it a spin. |
can I use l3build to install the package for tests? I don't think it is necessary to hide the \providecommand inside some test. Simply define always ... |
I've never tried that. We use You can use the file https://github.com/moewew/biblatex/blob/nohypertag/tex/latex/biblatex/biblatex.sty as a drop-in replacement for the current to usable values. That's what I usually do. |
Ok, one can partly install with l3build. It copies at least biblatex.sty. But one then has to exchange the start manually with.
Perhaps biblatex could use some defaults here, which work always? Apart from this the code works fine and the tagging is correct. As I said, I would provide the command always and not inside \blx@mknohyperref, that only complicates without much gain. |
I'll look into The tagging is already automatically changed for testing, so maybe it's just a matter of making that also happen for install. I didn't dare using |
natbib provides the commands since a long time. I think we would know by know if there is a package clash.
It uses the checkinit_hook to tag the file, but I'm not aware of a similar hook for installing. @josephwright would know better. But I wonder if you shouldn't change your version check and allow "DATE" and "VERSION", perhaps with a warning. That would make your own testing easier - you could even test with various biber versions etc. |
Tagging of citations are basically like adding links: some literals must be put around the citation which references/links to the bibliography.
The tagging code in latex lab makes therefore use of
\hyper@natlinkstart
andhyper@natlinkend
to add the tagging.Sadly this means that with biblatex (differently to natbib) tagging currently works correctly only if hyperref has been loaded as it doesn't use the commands if hyperref is not detected.
Could biblatex similar to natbib simply provide the commands and use them always? Then I would get something like this which is correctly tagged even if hyperref is not there:
The text was updated successfully, but these errors were encountered: