Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plomino accordion button not deactivated on non plomino RTE fields #4

Open
gaudenz opened this issue Apr 2, 2012 · 3 comments
Open

Comments

@gaudenz
Copy link

gaudenz commented Apr 2, 2012

Other than all the other plomino.tinymce buttons the accordion button is not deactiviated on non plomino RTE form fields. As it's not usable on non plomino fields it should be deactivated as well.

Is there a way to completely hide the buttons instead of just deactivating them? I think these buttons are somewhat confusing to simple content editors not aware of plomino even when deactivated.

@ebrehault
Copy link
Member

Regarding accordion: it is actually usable outside plomino (it is just a jqueryUI feature that can work in the entire Plone site).
So we considered it was nice to keep it everywhere but I agree it can be confusing, so the best thing would be to control that through configuration.

Regarding the other buttons: the easiest way we found was to disable them (using ed.controlManager.setDisabled), but if you know a way to hide them, it would be much better.

More generally about TinyMCE: the TinyMCE version used in Plone is quite old and some people are currently working on upgrading it. I hope the new version will provide interesting integration mechanisms, so we can improve plomino.tinymce.

@gaudenz
Copy link
Author

gaudenz commented Apr 2, 2012

On Mon, 2 Apr 2012 12:42:32 -0700, Eric BREHAULT reply@reply.github.com wrote:

Regarding accordion: it is actually usable outside plomino (it is just a jqueryUI feature that can work in the entire Plone site).
So we considered it was nice to keep it everywhere but I agree it can
be confusing, so the best thing would be to control that through
configuration.

Yes that would be nice. I did not know that it's actually just the
accordion plugin without any plomino specific functionality.

Regarding the other buttons: the easiest way we found was to disable
them (using ed.controlManager.setDisabled), but if you know a way to
hide them, it would be much better.

No I don't know TinyMCE that well. That's why I just submitted this
report instead of providing a patch...

More generally about TinyMCE: the TinyMCE version used in Plone is
quite old and some people are currently working on upgrading it. I
hope the new version will provide interesting integration mechanisms,
so we can improve plomino.tinymce.

Yes I know that. Progress is going very slow... Don't know what the new
TinyMCE will bring us.

Gaudenz

Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~

@ebrehault
Copy link
Member

I see there is a controlManager.destroy() method, but I do not know if it is supported in the current version

I will give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants