diff --git a/last_commit.txt b/last_commit.txt index 95d79b309b..389a44bf43 100644 --- a/last_commit.txt +++ b/last_commit.txt @@ -1,51 +1,52 @@ -Repository: plone.app.layout - - -Branch: refs/heads/master -Date: 2024-09-10T12:41:32+02:00 -Author: ale-rt (ale-rt) -Commit: https://github.com/plone/plone.app.layout/commit/35ea07b06e517452ef8db7cf6fb34a2ed6f5ebd3 - -Do not break if a syndication feed comes from a protected resource - -Files changed: -A news/374.bugfix -M plone/app/layout/links/tests/test_rssviewlet.py -M plone/app/layout/links/viewlets.py - -b'diff --git a/news/374.bugfix b/news/374.bugfix\nnew file mode 100644\nindex 00000000..42cdb6cc\n--- /dev/null\n+++ b/news/374.bugfix\n@@ -0,0 +1,2 @@\n+Do not break if a syndication feed comes from a protected resource.\n+[ale-rt]\ndiff --git a/plone/app/layout/links/tests/test_rssviewlet.py b/plone/app/layout/links/tests/test_rssviewlet.py\nindex ae12c856..aaea7e41 100644\n--- a/plone/app/layout/links/tests/test_rssviewlet.py\n+++ b/plone/app/layout/links/tests/test_rssviewlet.py\n@@ -1,11 +1,16 @@\n from plone.app.layout.links.viewlets import RSSViewlet\n from plone.app.layout.viewlets.tests.base import ViewletsTestCase\n+from plone.app.testing import login\n+from plone.app.testing import logout\n from plone.app.testing import setRoles\n from plone.app.testing import TEST_USER_ID\n+from plone.app.testing import TEST_USER_NAME\n from plone.base.interfaces import ISiteSyndicationSettings\n from plone.registry.interfaces import IRegistry\n from zope.component import getUtility\n \n+import re\n+\n \n class TestRSSViewletView(ViewletsTestCase):\n def test_RSSViewlet(self):\n@@ -30,3 +35,52 @@ def test_RSSViewlet(self):\n self.assertFalse(" -Commit: https://github.com/plone/plone.app.layout/commit/1f16d91a81de14eb4ff23722ce2a701ab85a72de - -Update plone/app/layout/links/tests/test_rssviewlet.py +Repository: plone.restapi + + +Branch: refs/heads/main +Date: 2024-09-11T20:06:13-07:00 +Author: Maurits van Rees (mauritsvanrees) +Commit: https://github.com/plone/plone.restapi/commit/057c59a04d4cb2e5d51e83cdab41b7e921aaae88 + +Fix error getting allow_discussion when p.a.discussion is not activated. (#1808) + +* Fix error getting allow_discussion value when p.a.discussion is not activated. + +This fixes an error in Plone 6.1 when the `plone.app.discussion` package is available but not activated in the Add-ons. +Problem is that the `conversation_view` is only defined when the browser layer of `plone.app.discussion` is found. +Sample error: + +``` +Traceback (innermost last): + Module ZPublisher.WSGIPublisher, line 181, in transaction_pubevents + Module ZPublisher.WSGIPublisher, line 391, in publish_module + Module ZPublisher.WSGIPublisher, line 285, in publish + Module ZPublisher.mapply, line 98, in mapply + Module ZPublisher.WSGIPublisher, line 68, in call_object + Module plone.rest.service, line 21, in __call__ + Module plone.restapi.services, line 19, in render + Module plone.restapi.services.content.get, line 16, in reply + Module plone.restapi.serializer.dxcontent, line 179, in __call__ + Module plone.restapi.serializer.dxcontent, line 142, in __call__ + Module plone.restapi.serializer.dxcontent, line 48, in get_allow_discussion_value + Module zope.component._api, line 113, in getMultiAdapter +zope.interface.interfaces.ComponentLookupError: +((<FolderishDocument at /PloneVolto/page>, + <WSGIRequest, URL=http://localhost:8080/PloneVolto/++api++/page/GET_application_json_>), + <InterfaceClass zope.interface.Interface>, 'conversation_view') +``` + +* Fix tests: Plone Site now gets allow_discussion false instead of null. Files changed: -M plone/app/layout/links/tests/test_rssviewlet.py - -b'diff --git a/plone/app/layout/links/tests/test_rssviewlet.py b/plone/app/layout/links/tests/test_rssviewlet.py\nindex aaea7e41..b90b8de7 100644\n--- a/plone/app/layout/links/tests/test_rssviewlet.py\n+++ b/plone/app/layout/links/tests/test_rssviewlet.py\n@@ -71,7 +71,7 @@ def test_RSSViewlet_with_private_objs(self):\n viewlet.update()\n result = viewlet.render()\n \n- # Verify that an anonymous users can see the RSS feed\n+ # Verify that an authenticated user can see the RSS feed\n # from the aggregator collection\n self.assertSetEqual(\n {\n' - -Repository: plone.app.layout - - -Branch: refs/heads/master -Date: 2024-09-10T09:11:32-07:00 -Author: David Glick (davisagli) -Commit: https://github.com/plone/plone.app.layout/commit/d1c00f7e9d41c5c0b8e208e6596cce8e8dccf3d8 - -Merge pull request #375 from plone/ale/374/fix-unauthorized - -Do not break if a syndication feed comes from a protected resource - -Files changed: -A news/374.bugfix -M plone/app/layout/links/tests/test_rssviewlet.py -M plone/app/layout/links/viewlets.py - -b'diff --git a/news/374.bugfix b/news/374.bugfix\nnew file mode 100644\nindex 00000000..42cdb6cc\n--- /dev/null\n+++ b/news/374.bugfix\n@@ -0,0 +1,2 @@\n+Do not break if a syndication feed comes from a protected resource.\n+[ale-rt]\ndiff --git a/plone/app/layout/links/tests/test_rssviewlet.py b/plone/app/layout/links/tests/test_rssviewlet.py\nindex ae12c856..b90b8de7 100644\n--- a/plone/app/layout/links/tests/test_rssviewlet.py\n+++ b/plone/app/layout/links/tests/test_rssviewlet.py\n@@ -1,11 +1,16 @@\n from plone.app.layout.links.viewlets import RSSViewlet\n from plone.app.layout.viewlets.tests.base import ViewletsTestCase\n+from plone.app.testing import login\n+from plone.app.testing import logout\n from plone.app.testing import setRoles\n from plone.app.testing import TEST_USER_ID\n+from plone.app.testing import TEST_USER_NAME\n from plone.base.interfaces import ISiteSyndicationSettings\n from plone.registry.interfaces import IRegistry\n from zope.component import getUtility\n \n+import re\n+\n \n class TestRSSViewletView(ViewletsTestCase):\n def test_RSSViewlet(self):\n@@ -30,3 +35,52 @@ def test_RSSViewlet(self):\n self.assertFalse("