Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator to check compat between Plone and Python version #55

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

davisagli
Copy link
Member

@davisagli davisagli commented Jan 12, 2025

Fixes #54

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plone 6.0 Python support shifted both its min and max versions up.

cookieplone/settings.py Outdated Show resolved Hide resolved
cookieplone/settings.py Outdated Show resolved Hide resolved
@davisagli
Copy link
Member Author

davisagli commented Jan 12, 2025

Plone 6.0 Python support shifted both its min and max versions up.

@stevepiercy Where? I thought I remembered that, but the 6.0.x branch of CMFPlone still includes support for Python 3.8 and not 3.13: https://github.com/plone/Products.CMFPlone/blob/6.0.x/setup.py#L24

Maybe @mauritsvanrees can remind me...

@stevepiercy
Copy link
Contributor

@stevepiercy
Copy link
Contributor

@davisagli
Copy link
Member Author

davisagli commented Jan 14, 2025

@stevepiercy @ericof Updated to match the actual release policy. I also removed 3.9 because cookieplone itself already doesn't support it (for some time). Which means the supported versions are now the same between Plone 6.0 and Plone 6.1, and I don't need to add the additional complexity of the new validator.

@davisagli davisagli merged commit 0c36dce into main Jan 14, 2025
3 checks passed
@davisagli davisagli deleted the validate-python-for-plone-version branch January 14, 2025 04:10
@stevepiercy
Copy link
Contributor

stevepiercy commented Jan 14, 2025

Wait, Cookieplone does not support Python 3.9? I did not know that, but looking at the blame for pyproject.toml, I see it never did. That means we have some more minor changes to make. We'll also need to update documentation for the Cookieplone installation.

But first, does Cookieplone still support Plone 6.0?

  1. We need to update pyproject.toml by adding 3.13 to the trove classifier and https://github.com/plone/cookieplone/blame/main/pyproject.toml#L82. Also maybe change its status from alpha while we're at it?
  2. In documentation, we state Python requirements for Plone 6.1, but not 6.0. We should state which versions of Plone are supported by Cookieplone.
  3. Plone 6.0 supports Python 3.9, but Cookieplone does not, so we'll need to make a note for anyone who wants to use Python 3.9 for Cookieplone that it is just not possible. Instead they must use the deprecated cookiecutter-plone-starter install method.

@davisagli @mauritsvanrees @ericof does all that sound right? Any other changes needed?

@davisagli
Copy link
Member Author

davisagli commented Jan 14, 2025

@stevepiercy

But first, does Cookieplone still support Plone 6.0?

Yes, and it still generates a project with the latest Plone 6.0 by default unless you say Yes for prerelease versions, since we don't have a final release of Plone 6.1 yet.

We need to update pyproject.toml by adding 3.13 to the trove classifier and https://github.com/plone/cookieplone/blame/main/pyproject.toml#L82. Also maybe change its status from alpha while we're at it?

Right, I missed this in my previous PR. Done in #56

In documentation, we state Python requirements for Plone 6.1, but not 6.0. We should state which versions of Plone are supported by Cookieplone.

Cookieplone can generate a backend for either Plone 6.0 or 6.1.

Plone 6.0 supports Python 3.9, but Cookieplone does not, so we'll need to make a note for anyone who wants to use Python 3.9 for Cookieplone that it is just not possible. Instead they must use the deprecated cookiecutter-plone-starter install method.

I would discourage anyone from starting a new project using such an old Python. Security support for Python 3.9 ends in October 2025.

@stevepiercy
Copy link
Contributor

Thanks! PR created: plone/documentation#1834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Python 3.13 for versions of Plone that support it
3 participants