-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validator to check compat between Plone and Python version #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plone 6.0 Python support shifted both its min and max versions up.
@stevepiercy Where? I thought I remembered that, but the 6.0.x branch of CMFPlone still includes support for Python 3.8 and not 3.13: https://github.com/plone/Products.CMFPlone/blob/6.0.x/setup.py#L24 Maybe @mauritsvanrees can remind me... |
@stevepiercy @ericof Updated to match the actual release policy. I also removed 3.9 because cookieplone itself already doesn't support it (for some time). Which means the supported versions are now the same between Plone 6.0 and Plone 6.1, and I don't need to add the additional complexity of the new validator. |
Wait, Cookieplone does not support Python 3.9? I did not know that, but looking at the blame for pyproject.toml, I see it never did. That means we have some more minor changes to make. We'll also need to update documentation for the Cookieplone installation. But first, does Cookieplone still support Plone 6.0?
@davisagli @mauritsvanrees @ericof does all that sound right? Any other changes needed? |
Yes, and it still generates a project with the latest Plone 6.0 by default unless you say Yes for prerelease versions, since we don't have a final release of Plone 6.1 yet.
Right, I missed this in my previous PR. Done in #56
Cookieplone can generate a backend for either Plone 6.0 or 6.1.
I would discourage anyone from starting a new project using such an old Python. Security support for Python 3.9 ends in October 2025. |
Thanks! PR created: plone/documentation#1834 |
Fixes #54