Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed plone instances to zope instances #1836

Open
wants to merge 1 commit into
base: 6.0
Choose a base branch
from

Conversation

alizgirl
Copy link

@alizgirl alizgirl commented Jan 17, 2025

First-time contributors

You must read and follow our First-time contributors.


Submit a pull request

Thank you for your contribution to the Plone Documentation.

Before submitting this pull request, please make sure you follow our guides:

Issue number

Description

Replaced "Plone instance" in the documentation repo with "Zope instance".

Add screenshots or links to a preview of the changes


📚 Documentation preview 📚: https://plone6--1836.org.readthedocs.build/

Copy link

boring-cyborg bot commented Jan 17, 2025

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, read Plone's Code of Conduct and Contribute to documentation, as this will greatly help the review process.

Welcome to the Plone community! 🎉

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get a quick review from @davisagli, since he brought up the original issue.

@@ -86,7 +86,7 @@ If the problem disappears, you will need to double-check the offending product.

(upgrading-troubleshooting-test-with-a-fresh-plone-instance-label)=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(upgrading-troubleshooting-test-with-a-fresh-plone-instance-label)=
(upgrading-troubleshooting-test-with-a-fresh-zope-instance-label)=

@stevepiercy stevepiercy requested a review from davisagli January 18, 2025 08:48
@stevepiercy
Copy link
Contributor

stevepiercy commented Jan 18, 2025

@alizgirl would you please change your pull request description from Fixes #1751 to Ref: #1751? There are instances of both "Plone instance" and "Zope / Plone instance" in the plone.api and plone.restapi documentation that need to be replaced in those repositories as well. That way it still links, but it won't close the issue until it is complete.

plone.api and plone.restapi get pulled into documentation as git submodules. See Editing external package documentation for more information. If you would like to submit a PR for those parts as well, I would greatly appreciate it.

Thank you!

@stevepiercy
Copy link
Contributor

Also you will need to update your branch to 6.0. You can do that by either clicking the Update branch button if available, or see Update your pull request from your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "Plone instance" and "Zope / Plone instance" with "Zope instance"
2 participants